-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package more llvm-* tools in the rust-dev component, for run-make-fulldeps tests #78131
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I’ll test this as suggested in #78110 (comment) @bors try |
⌛ Trying commit 8eb523bad6effc063f62ccf2fcaec9434d28d555 with merge 5c20da84f57ee6d76fe23ee7aa6d4bc18f4dda00... |
☀️ Try build successful - checks-actions, checks-azure |
With some more tools… @bors try |
⌛ Trying commit bc3dbc6 with merge 32bf523d699eabd43c5fef0b23bb5792884074be... |
☀️ Try build successful - checks-actions, checks-azure |
Alright, rust/src/bootstrap/bootstrap.py Lines 435 to 439 in 5546335
But if we land this PR as-is, that logic will still pick the last bors commit that touched the LLVM submodule which for now is before this PR and so does not have the extra tools. |
Hm, I wonder if we should just add a stamp file somewhere and check that as well in the list - I feel like that's the right call here. Would you be up for doing that? |
Sure, what would be a good location? |
Let's put it in src/bootstrap/llvm-submodule-stamp. (But I don't care strongly). |
I believe this is ready for review and landing |
@bors r+ rollup=never |
📌 Commit 99f99ca has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Fixes #78110