Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of item names for HIR #78345

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix handling of item names for HIR #78345

merged 2 commits into from
Nov 9, 2020

Commits on Nov 7, 2020

  1. Fix handling of item names for HIR 

    - Handle variants, fields, macros in `Node::ident()`
- Handle the crate root in `opt_item_name`
- Factor out `item_name_from_def_id` to reduce duplication
- Look at HIR before the DefId for `opt_item_name`

  This gives accurate spans, which are not available from serialized
  metadata.

- Don't panic on the crate root in `opt_item_name`
- Add comments
    @jyn514
    jyn514 committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    67d0db6 View commit details
    Browse the repository at this point in the history

  2. Remove unused from_hir call

    @jyn514
    jyn514 committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    f60fd49 View commit details
    Browse the repository at this point in the history