MinConstGenerics UI test for invalid values for bool & char #78428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
JulianKnodt
force-pushed
the
invalid_patterns
branch
2 times, most recently
from
09dca3c to
66ce776
Compare
lcnr
reviewed
Oct 27, 2020
varkor
added
A-const-generics
JulianKnodt
force-pushed
the
invalid_patterns
branch
from
66ce776 to
eb8e8bd
Compare
|
👍 @bors r+ rollup |
|
📌 Commit eb8e8bd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 29, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#77213 (rustdoc options to set default theme (and other settings)) - rust-lang#78224 (min_const_generics: allow ty param in repeat expr) - rust-lang#78428 (MinConstGenerics UI test for invalid values for bool & char) - rust-lang#78460 (Adjust turbofish help message for const generics) - rust-lang#78470 (Clean up intra-doc links in `std::path`) - rust-lang#78475 (fix a comment in validity check) - rust-lang#78478 (Add const generics tests for supertraits + dyn traits.) - rust-lang#78487 (Fix typo "compiltest") - rust-lang#78491 (Inline NonZeroN::from(n)) - rust-lang#78492 (Update books) - rust-lang#78494 (Fix typos) Failed merges: r? `@ghost`
|
cc #78433 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for
feature(min_const_generics)with some invalid values for bools and chars and ensures that they do not ICE and error with understandable messages.r? @lcnr