Fix warnings in tests #7857
Closed
Fix warnings in tests #7857
+33
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2013 02:18
Most of these are "unneccesary allocation" in bitv, for ~[false, ..] instead of [false, ..].
|
Rebased to current master. Didn't run all check yet. |
|
One thing we may want to consider is to either prohibit warnings in tests or allow warnings in all tests. Otherwise this is just going to continue cropping up and being a hassle. This may be better discussed on the mailing list, but what are your thoughts on this? |
bors
added a commit
that referenced
this pull request
Jul 19, 2013
Fix warnings that only show up when compiling the tests for libstd, libextra and one in librusti. Only trivial changes.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
Fix deploy script I broke this script in rust-lang#7502, so that the stable symlink isn't generated anymore. This reverts this change. changelog: none
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Sep 20, 2022
Refactor macro-by-example code I had a look at the MBE code because of rust-lang#7857. I found some easy readability wins, that might also _marginally_ improve perf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings that only show up when compiling the tests for libstd, libextra and one in librusti. Only trivial changes.