Print more info on bad frees with RUSTRT_TRACK_ALLOCATIONS #7859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2013 14:03
…LOCATIONS Probably the env var should be renamed from DETAILED_LEAKS but I'm leaving aside that breaking change for now.
| inline void memory_region::maybe_print_backtrace(const alloc_header *header) const { | ||
| # if RUSTRT_TRACK_ALLOCATIONS >= 3 | ||
| if (_detailed_leaks) { | ||
| backtrace_symbols_fd(header->bt + 1, header->btframes - 1, 2); |
There was a problem hiding this comment.
Will this work on Windows?
There was a problem hiding this comment.
I'm not sure. Is the concern that the backtrace_* glibc functions won't be available? At any rate, RUSTRT_TRACK_ALLOCATIONS >= 3 already uses those elsewhere.
There was a problem hiding this comment.
Ah, OK, if it's already used elsewhere then I guess it's fine.
bors
added a commit
that referenced
this pull request
Jul 19, 2013
I added these while tracking down heap corruption in Servo.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
Fix `question_mark` FP on custom error type Closes rust-lang#7859 rust-lang#7840 aims to ignore `question_mark` when the return type is custom, which is [covered here](https://github.com/rust-lang/rust-clippy/blob/df65291edd6b89a241fed483ab165c32df468746/tests/ui/question_mark.rs#L144-L149). But this fails when there is a call in conditional predicate changelog: [`question_mark`] Fix false positive when there is call in conditional predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these while tracking down heap corruption in Servo.