Retagging: do not retag 'raw reborrows' #78597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Nov 1, 2020
Stacked Borrows: test raw-ref-to-field with raw ptr tracking Adds a test for rust-lang/rust#78597 (blocked on that landing first)
|
@bors r+ |
|
📌 Commit 289c0d8 has been approved by |
bors
added
the
S-waiting-on-bors
camelid
added
the
A-MIR
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 3, 2020
Retagging: do not retag 'raw reborrows' When doing `&raw const (*raw_ptr).field`, we do not want any retagging; the original provenance should be fully preserved. Fixes rust-lang/miri#1608 Test added by rust-lang/miri#1614 Not sure whom to ask for review on this... `@oli-obk` can you have a look? Or maybe highfive makes a good choice.^^
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Nov 3, 2020
Stacked Borrows: test raw-ref-to-field with raw ptr tracking Adds a test for rust-lang/rust#78597 (blocked on that landing first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
&raw const (*raw_ptr).field, we do not want any retagging; the original provenance should be fully preserved.Fixes rust-lang/miri#1608
Test added by rust-lang/miri#1614
Not sure whom to ask for review on this... @oli-obk can you have a look? Or maybe highfive makes a good choice.^^