Corrected suggestion for generic parameters in function_item_references lint
#78659
Conversation
…ces` lint This lint was incorrectly suggesting casting a function to a pointer without specifying generic type parameters or const generics. This would cause a compiler error since the missing parameters couldn't be inferred. This commit fixed the suggestion and added a few tests with generics.
|
r? @oli-obk, following GitHub suggestions. |
JohnTitor
added
the
S-waiting-on-review
|
Another alternative is to not rebuild the name at all, but to grab the original snippet from the code being linted and just plainly reuse it here. You can use If that is not possible, I think it's fine to merge the current version, it covers the usually occurring situations. |
Thanks for pointing that out. I don't think it'll work though since the span we pass to |
|
That makes sense, thanks! @bors r+ |
|
📌 Commit ace02c4 has been approved by |
bors
added
S-waiting-on-bors
Corrected suggestion for generic parameters in `function_item_references` lint This commit handles functions with generic type parameters like you pointed out as well as const generics. Also this is probably a minor thing, but the type alias you used in the example doesn't show up so the suggestion right now would be `size_of::<[u8; 16]> as fn() ->`. This is because the lint checker works with MIR instead of HIR. I don't think we can get the alias at that point, but let me know if I'm wrong and there's a way to fix this. Also I put you as the reviewer, but I'm not sure if you want to review it or if it makes more sense to ask one of the original reviewers of this lint. closes rust-lang#78571
Rollup of 7 pull requests Successful merges: - rust-lang#77950 (Add support for SHA256 source file hashing) - rust-lang#78624 (Sync rustc_codegen_cranelift) - rust-lang#78626 (Improve errors about #[deprecated] attribute) - rust-lang#78659 (Corrected suggestion for generic parameters in `function_item_references` lint) - rust-lang#78687 (Suggest library/std when running all stage 0 tests) - rust-lang#78699 (Show more error information in lldb_batchmode) - rust-lang#78709 (Fix panic in bootstrap for non-workspace path dependencies.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This commit handles functions with generic type parameters like you pointed out as well as const generics. Also this is probably a minor thing, but the type alias you used in the example doesn't show up so the suggestion right now would be
size_of::<[u8; 16]> as fn() ->. This is because the lint checker works with MIR instead of HIR. I don't think we can get the alias at that point, but let me know if I'm wrong and there's a way to fix this. Also I put you as the reviewer, but I'm not sure if you want to review it or if it makes more sense to ask one of the original reviewers of this lint.closes #78571