Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #78792

Closed
wants to merge 44 commits into from

Commits on Jul 31, 2020

  1. Configuration menu
    Copy the full SHA
    7cae9e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Configuration menu
    Copy the full SHA
    3a46cca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d94258e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    14158f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Set the proper sysroot for clippy

    Clippy does its own runtime detection of the sysroot, which was
    incorrect in this case (it used the beta sysroot). This overrides the
    sysroot to use `stage0-sysroot` instead.
    
    - Get `x.py clippy` to work on nightly
    - Give a nice error message if nightly clippy isn't installed
    jyn514 committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    b3246e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51f8076 View commit details
    Browse the repository at this point in the history
  3. x.py fmt

    jyn514 committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    bdbb542 View commit details
    Browse the repository at this point in the history
  4. Allow using clippy with either beta or nightly

    Not 100% sure this will _always_ work, but it works currently.
    jyn514 committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    31ecd2a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    e099138 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Configuration menu
    Copy the full SHA
    b0df3f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Allow using 1/2/3/4 for x.py setup options

    This undocumented feature allows you to typo 'a' as '1'.
    jyn514 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    1e73724 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be01d54 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. inliner: Use substs_for_mir_body

    Changes from 68965 extended the kind of instances that are being
    inlined. For some of those, the `instance_mir` returns a MIR body that
    is already expressed in terms of the types found in substitution array,
    and doesn't need further substitution.
    
    Use `substs_for_mir_body` to take that into account.
    tmiasko committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    d2bc8a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Configuration menu
    Copy the full SHA
    2980367 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a54f043 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6bc8965 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f467b8d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7f839b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    55b4d21 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    60caf51 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fce2be0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1fb404b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6be97e2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9d11450 View commit details
    Browse the repository at this point in the history
  12. Fix more URLs

    GuillaumeGomez committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    16ed850 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    54a0a98 View commit details
    Browse the repository at this point in the history
  14. doc/rustc: promote aarch64-unknown-linux-gnu to tier 1

    This also adds a note about missing stack probes support, per the
    discussion on RFC 2959.
    pietroalbini committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    1274fae View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    874cbb8 View commit details
    Browse the repository at this point in the history
  16. Recognize private_intra_doc_links as a lint

    Previously, trying to allow this would give another error!
    
    ```
    warning: unknown lint: `private_intra_doc_links`
     --> private.rs:1:10
      |
    1 | #![allow(private_intra_doc_links)]
      |          ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `broken_intra_doc_links`
      |
      = note: `#[warn(unknown_lints)]` on by default
    
    warning: public documentation for `DocMe` links to private item `DontDocMe`
     --> private.rs:2:11
      |
    2 | /// docs [DontDocMe]
      |           ^^^^^^^^^ this item is private
      |
      = note: `#[warn(private_intra_doc_links)]` on by default
      = note: this link will resolve properly if you pass `--document-private-items`
    ```
    jyn514 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    eed0ceb View commit details
    Browse the repository at this point in the history
  17. Add PRIVATE_INTRA_DOC_LINKS to rustdoc special-casing

    This is really starting to get out of hand. Rustdoc should instead allow
    all lints in the rustdoc lint group.
    jyn514 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    47b21b8 View commit details
    Browse the repository at this point in the history
  18. Fix even more URLs

    GuillaumeGomez committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    99200f7 View commit details
    Browse the repository at this point in the history
  19. Infer the default host target from the host toolchain if possible

    This fixes ongoing issues where x.py will detect the wrong host triple
    between MSVC and GNU.
    
    - Add line to changelog
    jyn514 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    3863dee View commit details
    Browse the repository at this point in the history
  20. Get --fix working for everything except rustdoc

    Here's the error for rustdoc:
    
    ```
    Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    error: no library targets found in package `rustdoc-tool`
    ```
    jyn514 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    8d2fa72 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Rollup merge of rust-lang#74979 - maekawatoshiki:fix, r=Mark-Simulacrum

    `#![deny(unsafe_op_in_unsafe_fn)]` in sys/hermit
    
    Partial fix of rust-lang#73904.
    
    This encloses ``unsafe`` operations in ``unsafe fn`` in ``sys/hermit``.
    Some unsafe blocks are not well documented because some system-based functions lack documents.
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    4f4ce1c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#77351 - jyn514:clippy-sysroot, r=Mark-Simul…

    …acrum
    
    Fix `x.py clippy`
    
    I don't think this ever worked.
    
    Fixes rust-lang#77309. `--fix` support is a work in progress, but works for a very small subset of `libtest`.
    
    This works by using the host `cargo-clippy` driver; it does not use `stage0.txt` at all. To mitigate confusion from this, it gives an error if you don't have `rustc +nightly` as the default rustc in `$PATH`. Additionally, it means that bootstrap can't set `RUSTC`; this makes it no longer possible for clippy to detect the sysroot itself. Instead, bootstrap passes the sysroot to cargo.
    
    r? `@ghost`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    3124e79 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#77856 - GuillaumeGomez:automatic-links-lint…

    …, r=jyn514,ollie27
    
    Add non_autolinks lint
    
    Part of rust-lang#77501.
    
    r? `@jyn514`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    d6bd33d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#78114 - jyn514:private, r=oli-obk

    Recognize `private_intra_doc_links` as a lint
    
    Previously, trying to allow this would give another error!
    
    ```
    warning: unknown lint: `private_intra_doc_links`
     --> private.rs:1:10
      |
    1 | #![allow(private_intra_doc_links)]
      |          ^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `broken_intra_doc_links`
      |
      = note: `#[warn(unknown_lints)]` on by default
    
    warning: public documentation for `DocMe` links to private item `DontDocMe`
     --> private.rs:2:11
      |
    2 | /// docs [DontDocMe]
      |           ^^^^^^^^^ this item is private
      |
      = note: `#[warn(private_intra_doc_links)]` on by default
      = note: this link will resolve properly if you pass `--document-private-items`
    ```
    
    Fixes the issue found in rust-lang#77249 (comment).
    
    r? `@Manishearth`
    
    Does anyone know why this additional step is necessary? It seems weird this has to be declared in 3 different places.
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    e422bef View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#78228 - pietroalbini:finally, r=Mark-Simula…

    …crum
    
    Promote aarch64-unknown-linux-gnu to Tier 1
    
    This PR promotes the `aarch64-unknown-linux-gnu` target to Tier 1, as proposed by [RFC 2959]:
    
    * The `aarch64-gnu` CI job is moved from `auto-fallible` to `auto`.
    * The platform support documentation is updated, uplifting the target to Tiert 1 with a note about missing stack probes support.
    * Building the documentation is enabled for the target, as we produce the `rust-docs` component for all Tier 1 platforms.
    
    [RFC 2959]: rust-lang/rfcs#2959
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a8d4297 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#78437 - ssomers:btree_no_ord_at_node_level,…

    … r=Mark-Simulacrum
    
    BTreeMap: stop mistaking node for an orderly place
    
    A second mistake in rust-lang#77612 was to ignore the node module's rightful comment "this module doesn't care whether the entries are sorted". And there's a much simpler way to visit the keys in order, if you check this separately from a single pass checking everything.
    
    r? `@Mark-Simulacrum`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    d22cc21 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#78476 - RalfJung:btree-alias, r=Mark-Simula…

    …crum
    
    fix some incorrect aliasing in the BTree
    
    This line is wrong:
    ```
    ptr::copy(slice.as_ptr().add(idx), slice.as_mut_ptr().add(idx + 1), slice.len() - idx);
    ```
    When `slice.as_mut_ptr()` is called, that creates a mutable reference to the entire slice, which invalidates the raw pointer previously returned by `slice.as_ptr()`. (Miri currently misses this because raw pointers are not tracked properly.)
    
    Cc `@ssomers`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    e6f601e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#78513 - jyn514:rustup-toolchain, r=Mark-Sim…

    …ulacrum
    
    Infer the default host target from the host toolchain if possible
    
    - `beta-x86_64-unknown-linux-gnu` has beta stripped
    - `rustc2` is ignored
    
    This fixes ongoing issues where x.py will detect the wrong host triple
    between MSVC and GNU.
    
    I don't think this will break anyone's workflow - I'd be very surprised if you a) had no `[build]` section in `config.toml`, b) had rustc installed, and c) expected the default target to be something other than the default target used by `rustc`. But I could be wrong - I'm happy to hear user stories :)
    
    Fixes rust-lang#78150.
    
    r? `@Mark-Simulacrum`
    cc `@Lokathor`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    691cfad View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#78514 - jyn514:setup-number, r=Mark-Simulacrum

    Allow using 1/2/3/4 for `x.py setup` options
    
    This undocumented feature allows you to typo 'a' as '1'.
    
    r? `@Mark-Simulacrum`
    cc `@Lokathor`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    03eec1d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#78538 - ssomers:btree_testing_rng, r=Mark-S…

    …imulacrum
    
    BTreeMap: document a curious assumption in test cases
    
    r? `@Mark-Simulacrum`
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    f926cd3 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#78674 - tmiasko:inline-substs-for-mir-body,…

    … r=oli-obk
    
    inliner: Use substs_for_mir_body
    
    Changes from 68965 extended the kind of instances that are being
    inlined. For some of those, the `instance_mir` returns a MIR body that
    is already expressed in terms of the types found in substitution array,
    and doesn't need further substitution.
    
    Use `substs_for_mir_body` to take that into account.
    
    Resolves rust-lang#78529.
    Resolves rust-lang#78560.
    Dylan-DPC authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    e71644d View commit details
    Browse the repository at this point in the history