Experiment: Add #[may_ignore] and use that for String::write_fmt. #78822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ou-se
added
A-fmt
m-ou-se
force-pushed
the
string-write-fmt-may-ignore
branch
from
52268de
to
bc6e001
Compare
m-ou-se
force-pushed
the
string-write-fmt-may-ignore
branch
6 times, most recently
from
037a136
to
5546637
Compare
m-ou-se
force-pushed
the
string-write-fmt-may-ignore
branch
from
5546637
to
27c50a0
Compare
Closed
|
☔ The latest upstream changes (presumably #78889) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
bors
added
the
S-waiting-on-author
|
@m-ou-se do you still plan to work on this? |
|
I no longer thing String::write_fmt should ignore errors, since Display implementations can still return an Err (even though they probably shouldn't). So panicking would be better than ignoring. (Althought that will probably not be optimized away even when just formatting things that can never fail. :( ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out some idea to improve
write!(string, ..).r? @ghost