Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit test for const param promotion #78996

Merged
merged 1 commit into from
Nov 13, 2020
Merged

add explicit test for const param promotion #78996

merged 1 commit into from
Nov 13, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 12, 2020

@lcnr lcnr added F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Nov 12, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2020
@RalfJung
Copy link
Member

RalfJung commented Nov 13, 2020 •
edited
Loading

This seems fine to me, but Cc @rust-lang/wg-const-eval to be sure.

I wonder if we should start having a separate folder for promotion tests; currently they seem quite scattered about.

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 13, 2020

📌 Commit c56add0 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2020
@RalfJung
Copy link
Member

@bors rollup

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2020
@bors
Auto merge of rust-lang#79017 - GuillaumeGomez:rollup-5orhudd, r=Guil…
f2a11a2 
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#77151 (Add regression test for issue rust-lang#76042)
 - rust-lang#77996 (Doc change: Remove mention of `fnv` in HashMap)
 - rust-lang#78463 (Add type to `ConstKind::Placeholder`)
 - rust-lang#78984 (Rustdoc check option)
 - rust-lang#78985 (add dropck test for const params)
 - rust-lang#78996 (add explicit test for const param promotion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7ea8e32 into rust-lang:master Nov 13, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 13, 2020
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@RalfJung RalfJung

Labels
F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @RalfJung @bors @oli-obk @rust-highfive @rustbot