Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rustdoc::formats::cache::Impl #79452

Closed
wants to merge 1 commit into from

Conversation

camelid
Copy link
Member

@camelid camelid commented Nov 26, 2020

r? @jyn514

@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 26, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2020
@camelid
Copy link
Member Author

camelid commented Nov 26, 2020

Actually, this is trickier than I thought because it looks like there are parts that need some fields on Item. Also, I know that you (Joshua) are planning to get rid of clean anyway, so perhaps not worth the effort.

@camelid camelid closed this Nov 26, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 19, 2021

I do think this is a useful change, but I think we should try to implement #83183 first since otherwise we'd end up rewriting a lot of the same code:

error[E0599]: no method named `stable_since` found for struct `types::Impl` in the current scope
    --> src/librustdoc/html/render/print_item.rs:613:43
     |
613  |                     implementor.impl_item.stable_since(cx.tcx()).as_deref(),
     |                                           ^^^^^^^^^^^^ method not found in `types::Impl`
     | 
    ::: src/librustdoc/clean/types.rs:2034:1
     |
2034 | crate struct Impl {
     | ----------------- method `stable_since` not found for this

error[E0599]: no method named `const_stable_since` found for struct `types::Impl` in the current scope
    --> src/librustdoc/html/render/print_item.rs:614:43
     |
614  |                     implementor.impl_item.const_stable_since(cx.tcx()).as_deref(),
     |                                           ^^^^^^^^^^^^^^^^^^ method not found in `types::Impl`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants