-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch some links in compiler/ to intra-doc links #79612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
labels
Dec 1, 2020
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 1, 2020
I tried switching more than this originally, but ran into #74481. |
jyn514
force-pushed
the
compiler-links
branch
from
December 2, 2020 03:10
7662fad
to
1ba5fc0
Compare
jyn514
changed the title
Switch compiler/ to intra-doc links
Switch some links in compiler/ to intra-doc links
Dec 2, 2020
crlf0710
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 18, 2020
r? @Aaron1011 |
r=me with the commits squashed |
rustc_lint and rustc_lint_defs weren't switched because they're included in the compiler book and so can't use intra-doc links.
jyn514
force-pushed
the
compiler-links
branch
from
December 18, 2020 20:23
1ba5fc0
to
35f16c6
Compare
@bors r=Aaron1011 rollup |
📌 Commit 35f16c6 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 18, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 19, 2020
Switch some links in compiler/ to intra-doc links
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#78083 (Stabilize or_insert_with_key) - rust-lang#79211 (Add the "async" and "promise" doc aliases to `core::future::Future`) - rust-lang#79612 (Switch some links in compiler/ to intra-doc links) - rust-lang#80068 (Add `&mut` as an alias for 'reference' primitive) - rust-lang#80129 (docs: Edit rustc_ast::token::Token) - rust-lang#80133 (Suppress `CONST_ITEM_MUTATION` lint if a dereference occurs anywhere) - rust-lang#80155 (Fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.