const_evaluatable_checked: fix occurs check #79635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
added
F-generic_const_exprs
crlf0710
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 806c728 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79615
this is kind of a hack because we use
TypeRelationfor both theGeneralizerand theConstInferUnifierbut i am not sure if there is a useful way to disentangle this without unnecessarily duplicating some code.The error in the added test is kind of unavoidable until we erase the unused substs of
ConstKind::Unevaluated. We talked a bit about this in the cg lazy norm meeting (https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/lazy_normalization_consts)