-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Enable parallel compiler by default #79706
Conversation
It's been over a year since we last tried this - let's see what the performance looks like now.
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 6053526 with merge df18da5db6c9c66898610a29a2401e762c860f0a... |
This comment has been minimized.
This comment has been minimized.
There are a few cases where the exact error changes. |
☀️ Try build successful - checks-actions |
Queued df18da5db6c9c66898610a29a2401e762c860f0a with parent 2218520, future comparison URL. |
Finished benchmarking try commit (df18da5db6c9c66898610a29a2401e762c860f0a): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Instruction count difference seems to have gotten a bit worse since the last perf test, however wall time difference seems to have gotten a bit more positive than it already was. |
Going to do another perf run with only a single thread to see if the overhead in this case has been reduced. @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit dec8166 with merge 7cd4a2ec5195e5df4cb2f7292aa53fa3d870cd9f... |
The bootstrap times are actually really interesting, because perf runs that build under -j1 - which should mean that we get zero parallelism opportunity. I guess that means that either our -j1 isn't quite working or something else interesting is going on (e.g., we get better scheduling under parallel mode). Either way I'm not sure I'd trust these numbers given that... Overall though other than that confusing element these do indeed look pretty good. We can't trust the instruction counts I think pretty much at all for this kind of assessment. |
☀️ Try build successful - checks-actions |
Queued 7cd4a2ec5195e5df4cb2f7292aa53fa3d870cd9f with parent 2218520, future comparison URL. |
Finished benchmarking try commit (7cd4a2ec5195e5df4cb2f7292aa53fa3d870cd9f): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Now it's way less red in the instruction counts (single digit regressions), but there are regressions for the bootstrap timings. |
This is a rebase of #75651.
#78201 may have reduced the overhead of parallel rustc.