Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Features Rc::clone_raw() and Arc::clone_raw() #79952

Closed
wants to merge 13 commits into from
Closed

Adding Features Rc::clone_raw() and Arc::clone_raw() #79952

wants to merge 13 commits into from

Conversation

HTGAzureX1212
Copy link
Contributor

Closes #48108.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2020
@Mark-Simulacrum
Copy link
Member

I think given increment/decrement strong count stabilized in #79285, this doesn't add too much value over using those and then from_raw (or so).

@kennytm
Copy link
Member

kennytm commented Dec 24, 2020

i suggest we close this since #79285 has entered FCP

@HTGAzureX1212
Copy link
Contributor Author

Closing in favour of #79285 entering its Final Comment Period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Rc::clone_raw (and for Arc)
5 participants