Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc rustbuild improvements when the LLVM backend isn't used #79970

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Misc rustbuild improvements when the LLVM backend isn't used #79970

merged 2 commits into from
Dec 13, 2020

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 12, 2020

  • Don't checkout llvm-project
  • Don't require cmake and ninja

Fixes #78564

@bjorn3 bjorn3 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 12, 2020
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

This looks fine to me.

@bors
Copy link
Contributor

bors commented Dec 12, 2020

📌 Commit d79e19f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#79970 - bjorn3:no_unnecessary_llvm_checkout…
e08bda9 
…, r=Mark-Simulacrum

Misc rustbuild improvements when the LLVM backend isn't used

* Don't checkout llvm-project
* Don't require cmake and ninja

Fixes rust-lang#78564
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 12, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Dec 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2020
@bors
Auto merge of rust-lang#79994 - JohnTitor:rollup-43wl2uj, r=JohnTitor
1281315 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#79360 (std::iter: document iteration over `&T` and `&mut T`)
 - rust-lang#79398 (Link loop/for keyword)
 - rust-lang#79834 (Remove deprecated linked_list_extras methods.)
 - rust-lang#79845 (Fix rustup support in default_build_triple for python3)
 - rust-lang#79940 (fix more clippy::complexity findings)
 - rust-lang#79942 (Add post-init hook for static memory for miri.)
 - rust-lang#79954 (Fix building compiler docs with stage 0)
 - rust-lang#79963 (Fix typo in `DebruijnIndex` documentation)
 - rust-lang#79970 (Misc rustbuild improvements when the LLVM backend isn't used)
 - rust-lang#79973 (rustdoc light theme: Fix CSS for selected buttons)
 - rust-lang#79984 (Remove an unused dependency that made `rustdoc` crash)
 - rust-lang#79985 (Fixes submit event of the search input)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d90084c into rust-lang:master Dec 13, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 13, 2020
@bjorn3 bjorn3 deleted the no_unnecessary_llvm_checkout branch December 13, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

bootstrap: Don't mandate cmake and ninja when the LLVM backend is disabled
5 participants
@bjorn3 @rust-highfive @Mark-Simulacrum @bors @rustbot