Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of clean::Deprecation #80041

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Get rid of clean::Deprecation #80041

merged 1 commit into from
Dec 16, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 14, 2020

This brings the size of item.deprecation from 56 to 16 bytes. Helps with #79103 and #76382, in the same vein as #79957.

r? @GuillaumeGomez

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. labels Dec 14, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2020
This brings the size of `item.deprecation` from 56 to 16 bytes.
@jyn514
Copy link
Member Author

jyn514 commented Dec 15, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Dec 15, 2020

⌛ Trying commit 7d45243 with merge b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f...

@camelid camelid added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2020
@bors
Copy link
Contributor

bors commented Dec 15, 2020

☀️ Try build successful - checks-actions
Build commit: b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f (b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f)

@rust-timer
Copy link
Collaborator

Queued b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f with parent 8b3ee82, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2020
@jyn514
Copy link
Member Author

jyn514 commented Dec 15, 2020

The changes in instruction counts are marginal, but -.5% on max-rss. I think this is worth landing just for the cleanup honestly.

@GuillaumeGomez
Copy link
Member

Just the fact that it removes code makes it worth it. 😄

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 15, 2020

📌 Commit 7d45243 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2020
@bors
Copy link
Contributor

bors commented Dec 15, 2020

⌛ Testing commit 7d45243 with merge 0298b3901dd66b407dfb15352c06e83bea0eecb4...

@bors
Copy link
Contributor

bors commented Dec 15, 2020

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2020
@jyn514
Copy link
Member Author

jyn514 commented Dec 16, 2020

The dist-x86_64-apple job failed, but there's no build log to see why :/ @rust-lang/infra do you know what's going wrong here?

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 16, 2020
@bors
Copy link
Contributor

bors commented Dec 16, 2020

⌛ Testing commit 7d45243 with merge 90f4b52...

@bors
Copy link
Contributor

bors commented Dec 16, 2020

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 90f4b52 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2020
@bors bors merged commit 90f4b52 into rust-lang:master Dec 16, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 16, 2020
@jyn514 jyn514 deleted the shrink-item branch December 16, 2020 13:34
@pietroalbini
Copy link
Member

do you know what's going wrong here?

Not having logs usually happens when the machine is disconnected from the network / crashes. My guess is that's probably https://www.githubstatus.com/incidents/3jr0nb7zjpbm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants