-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of clean::Deprecation
#80041
Conversation
This brings the size of `item.deprecation` from 56 to 16 bytes.
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 7d45243 with merge b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f... |
☀️ Try build successful - checks-actions |
Queued b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f with parent 8b3ee82, future comparison URL. |
Finished benchmarking try commit (b63794ab1dbc729a6d5a8620d0fd64a6afb4d10f): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
The changes in instruction counts are marginal, but -.5% on max-rss. I think this is worth landing just for the cleanup honestly. |
Just the fact that it removes code makes it worth it. 😄 @bors: r+ |
📌 Commit 7d45243 has been approved by |
⌛ Testing commit 7d45243 with merge 0298b3901dd66b407dfb15352c06e83bea0eecb4... |
💔 Test failed - checks-actions |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The dist-x86_64-apple job failed, but there's no build log to see why :/ @rust-lang/infra do you know what's going wrong here? @bors retry |
☀️ Test successful - checks-actions |
Not having logs usually happens when the machine is disconnected from the network / crashes. My guess is that's probably https://www.githubstatus.com/incidents/3jr0nb7zjpbm. |
This brings the size of
item.deprecation
from 56 to 16 bytes. Helps with #79103 and #76382, in the same vein as #79957.r? @GuillaumeGomez