Skip to content

Add more documentation to Diagnostic and DiagnosticBuilder #80046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2020
Merged

Add more documentation to Diagnostic and DiagnosticBuilder #80046

merged 2 commits into from
Dec 18, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 15, 2020

@camelid camelid added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Dec 15, 2020
@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2020
@lcnr
Copy link
Contributor

lcnr commented Dec 15, 2020

👍

do we check that all intradoc links were successfully resolved?

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 15, 2020

📌 Commit 6f61866f15cc79dc20e39613f08c94f2f6b18f6a has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2020
@lcnr
Copy link
Contributor

lcnr commented Dec 15, 2020

looks like CI is still failing

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2020
@camelid
Copy link
Member Author

camelid commented Dec 15, 2020

do we check that all intradoc links were successfully resolved?

We have a linkchecker script that should be run by CI.

@camelid
Copy link
Member Author

camelid commented Dec 15, 2020

Actually, I'm not sure if it works for compiler docs though.

@camelid
Copy link
Member Author

camelid commented Dec 15, 2020

cc https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/docs.20based.20on.20macro.20input

@camelid
Copy link
Member Author

camelid commented Dec 16, 2020

@lcnr should be good to go now

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2020
@lcnr
Copy link
Contributor

lcnr commented Dec 17, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 17, 2020

📌 Commit 10487cd has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2020
@bors
Auto merge of rust-lang#80138 - Dylan-DPC:rollup-qamsfyh, r=Dylan-DPC
f3800db 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#78164 (Prefer regions with an `external_name` in `approx_universal_upper_bound`)
 - rust-lang#80003 (Fix overflow when converting ZST Vec to VecDeque)
 - rust-lang#80023 (Enhance error message when misspelled label to value in break expression)
 - rust-lang#80046 (Add more documentation to `Diagnostic` and `DiagnosticBuilder`)
 - rust-lang#80109 (Remove redundant and unreliable coverage test results)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da89dbb into rust-lang:master Dec 18, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 18, 2020
@camelid camelid deleted the diag-docs branch December 18, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr approved these changes

Assignees

@lcnr lcnr

Labels

A-diagnostics Area: Messages for errors, warnings, and lints A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

5 participants

@camelid @rust-highfive @lcnr @bors @rustbot