Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more timing info to rustdoc #80071

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Add more timing info to rustdoc #80071

merged 1 commit into from
Dec 22, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 16, 2020

This helped me confirm in #79103 (comment) that get_blanket_impls is indeed what's taking all the time on stm32.

r? @Mark-Simulacrum

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-compiler-performance Working group: Compiler Performance A-self-profile Area: Self-profiling feature of the compiler labels Dec 16, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2020
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never (perf diff is harder to interpret with changing self-profile info)

@bors
Copy link
Contributor

bors commented Dec 22, 2020

📌 Commit ffa7a01 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2020
@bors
Copy link
Contributor

bors commented Dec 22, 2020

⌛ Testing commit ffa7a01 with merge 353f3a3...

@bors
Copy link
Contributor

bors commented Dec 22, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 353f3a3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 22, 2020
@bors bors merged commit 353f3a3 into rust-lang:master Dec 22, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 22, 2020
@jyn514 jyn514 deleted the timings branch December 22, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-self-profile Area: Self-profiling feature of the compiler merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-compiler-performance Working group: Compiler Performance
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-log-analyzer @Mark-Simulacrum @bors @rust-highfive @rustbot