Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc] Calculate stability, const_stability, and deprecation on-demand #80095

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 16, 2020

Previously, they would always be calculated ahead of time, which bloated the size of clean::Item.

Builds on #80090 and should not be merged before. Helps with #79103 and #76382.

cc #80014 (comment)

This brings Item down to 568 bytes, down from 616.

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 16, 2020
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2020
@rust-log-analyzer

This comment has been minimized.

@bors

This comment has been minimized.

Previously, they would always be calculated ahead of time, which bloated
the size of `clean::Item`.
@jyn514 jyn514 force-pushed the stability-on-demand branch from 7ec3996 to 1523f67 Compare December 18, 2020 14:27
@jyn514 jyn514 removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 18, 2020
@jyn514
Copy link
Member Author

jyn514 commented Dec 22, 2020

Oops, I never ran perf on this.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Dec 22, 2020

⌛ Trying commit 1523f67 with merge bf5ffc1e18462e62769c4e09320da201c8a72ac6...

@bors
Copy link
Contributor

bors commented Dec 22, 2020

☀️ Try build successful - checks-actions
Build commit: bf5ffc1e18462e62769c4e09320da201c8a72ac6 (bf5ffc1e18462e62769c4e09320da201c8a72ac6)

@rust-timer
Copy link
Collaborator

Queued bf5ffc1e18462e62769c4e09320da201c8a72ac6 with parent 353f3a3, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 22, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (bf5ffc1e18462e62769c4e09320da201c8a72ac6): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 23, 2020
@jyn514
Copy link
Member Author

jyn514 commented Dec 23, 2020

Ooh, very nice! -3.5% on instruction counts, max of -2.9% on max-rss.

@bors r=GuillaumeGomez rollup=never

@bors
Copy link
Contributor

bors commented Dec 23, 2020

📌 Commit 1523f67 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2020
@bors
Copy link
Contributor

bors commented Dec 23, 2020

⌛ Testing commit 1523f67 with merge 18b745e...

@bors
Copy link
Contributor

bors commented Dec 23, 2020

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 18b745e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 23, 2020
@bors bors merged commit 18b745e into rust-lang:master Dec 23, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 23, 2020
@jyn514 jyn514 deleted the stability-on-demand branch December 23, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants