-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rustdoc] Calculate stability, const_stability, and deprecation on-demand #80095
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Previously, they would always be calculated ahead of time, which bloated the size of `clean::Item`.
7ec3996
to
1523f67
Compare
Oops, I never ran perf on this. @bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit 1523f67 with merge bf5ffc1e18462e62769c4e09320da201c8a72ac6... |
☀️ Try build successful - checks-actions |
Queued bf5ffc1e18462e62769c4e09320da201c8a72ac6 with parent 353f3a3, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (bf5ffc1e18462e62769c4e09320da201c8a72ac6): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Ooh, very nice! -3.5% on instruction counts, max of -2.9% on max-rss. @bors r=GuillaumeGomez rollup=never |
📌 Commit 1523f67 has been approved by |
☀️ Test successful - checks-actions |
Previously, they would always be calculated ahead of time, which bloated the size of
clean::Item
.Builds on #80090 and should not be merged before. Helps with #79103 and #76382.
cc #80014 (comment)
This brings
Item
down to 568 bytes, down from 616.