-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DefPath
from Visibility
and calculate it on demand
#80099
Conversation
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
b37312d
to
7c75770
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7c75770
to
4b4a260
Compare
This comment has been minimized.
This comment has been minimized.
4b4a260
to
a2fb4b9
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit a2fb4b9 with merge fbe5dedd7d90604c50736a818a6ea08e195a377e... |
☀️ Try build successful - checks-actions |
Queued fbe5dedd7d90604c50736a818a6ea08e195a377e with parent 353f3a3, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (fbe5dedd7d90604c50736a818a6ea08e195a377e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
-.5% on instructions, -.6% on max-rss. @bors r=GuillaumeGomez rollup=never |
📌 Commit a2fb4b9 has been approved by |
☀️ Test successful - checks-actions |
Depends on #80090 and should not be merged before. Helps with #79103 and #76382.
cc #80014 (comment) - @nnethercote I figured it out! It was simpler than I expected :)
This brings the size of
clean::Visibility
down from 40 bytes to 8.Note that this does not remove
clean::Visibility
, even though it's now basically the same asty::Visibility
, because theInvsible
variant means something different fromInherited
and I thought it would be be confusing to merge the two. See the new comments onimpl Clean for ty::Visibility
for details.