Add array search aliases #80159
Merged
Add array search aliases #80159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
A-docs
rust-highfive
added
the
S-waiting-on-review
| @@ -478,8 +478,10 @@ mod prim_unit {} | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| mod prim_pointer {} | |||
|
|
|||
| #[doc(alias = "[;]")] | |||
| #[doc(alias = "[T;N]")] // unfortunately, rustdoc doesn't have fuzzy search for aliases | |||
| #[doc(alias = "[T; N]")] | |||
There was a problem hiding this comment.
I'm not sure those aliases will be super useful... Maybe []?
There was a problem hiding this comment.
@GuillaumeGomez [] is already used for slices: https://doc.rust-lang.org/std/?search=%5B%5D. Is it possible to have two different types with the same alias?
There was a problem hiding this comment.
Ok, I changed [;] to []. I still think [T; N] is useful because it's used in the documentation a lot.
There was a problem hiding this comment.
Maybe keep [;] too then? XD
|
@bors r+ rollup |
|
📌 Commit f2743a5 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 21, 2020
Add array search aliases Missed this in rust-lang#80068. This one will really fix rust-lang#46075. The last alias especially I'm a little unsure about - maybe fuzzy search should be fixed in rustdoc instead? Happy to make that change although I'd have to figure out how. r? `@m-ou-se` although cc `@GuillaumeGomez` for the search issue.
This was referenced Dec 21, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#80159 (Add array search aliases) - rust-lang#80166 (Edit rustc_middle docs) - rust-lang#80170 (Fix ICE when lookup method in trait for type that have bound vars) - rust-lang#80171 (Edit rustc_middle::ty::TyKind docs) - rust-lang#80199 (also const-check FakeRead) - rust-lang#80211 (Handle desugaring in impl trait bound suggestion) - rust-lang#80236 (Use pointer type in AtomicPtr::swap implementation) - rust-lang#80239 (Update Clippy) - rust-lang#80240 (make sure installer only creates directories in DESTDIR) - rust-lang#80244 (Cleanup markdown span handling) - rust-lang#80250 (Minor cleanups in LateResolver) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in #80068. This one will really fix #46075.
The last alias especially I'm a little unsure about - maybe fuzzy search should be fixed in rustdoc instead? Happy to make that change although I'd have to figure out how.
r? @m-ou-se although cc @GuillaumeGomez for the search issue.