Skip dsymutil by default for compiler bootstrap
#80213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dsymutil` adds time to builds on Apple platforms for no clear benefit, and also makes it more difficult for debuggers to find debug info. The compiler currently defaults to running `dsymutil` to preserve its historical default, but when compiling the compiler itself, we skip it by default since we know it's safe to do so in that case.
rust-highfive
added
the
S-waiting-on-review
jyn514
added
T-bootstrap
|
@bors r+ cc @alexcrichton (this affects to an extent the stabilization PR of yours) |
|
📌 Commit e628fcf has been approved by |
bors
added
S-waiting-on-bors
|
We should also look at doing the same in compiletest (possibly modulo the debugger tests?). @bors rollup=never for better bisection |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dsymutiladds time to builds on Apple platforms for no clear benefit, and also makes it more difficult for debuggers to find debug info (which @pnkfelix highlighted on Zulip). The compiler currently defaults to runningdsymutilto preserve its historical default, but when compiling the compiler itself, we skip it by default since we know it's safe to do so in that case.r? @nagisa