Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate metadata by iterating on DefId instead of traversing the HIR tree #80347

Closed
wants to merge 16 commits into from
Closed

Generate metadata by iterating on DefId instead of traversing the HIR tree #80347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6337594
Iterate on variances_of.
cjgillot Dec 6, 2020
dda31b9
Iterate on generics_of.
cjgillot Dec 6, 2020
58bca6f
Iterate on explicit_predicates.
cjgillot Dec 6, 2020
4223db7
Iterate on inferred_outlives.
cjgillot Dec 6, 2020
c74a355
Filter generics.
cjgillot Jan 16, 2021
fcd6f20
Iterate for super_predicates.
cjgillot Feb 6, 2021
1842886
Infallible version of type_of.
cjgillot Dec 23, 2020
83122e6
Infallible version of fn_sig.
cjgillot Dec 23, 2020
488c368
Infallible version of explicit_item_bounds.
cjgillot Dec 23, 2020
faee780
Iterate on type_of.
cjgillot Dec 6, 2020
478da8f
Filter type_of.
cjgillot Jan 16, 2021
f738c20
Iterate on fn_sig.
cjgillot Dec 13, 2020
7aedff6
Iterate on explicit_item_bounds.
cjgillot Dec 18, 2020
45867ec
Filter fn_sig.
cjgillot Jan 16, 2021
97008d4
Filter explicit_item_bounds.
cjgillot Feb 5, 2021
4a5468b
Add inline directives.
cjgillot Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/rustc_incremental/src/persist/dirty_clean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ const CFG: Symbol = sym::cfg;
// Base and Extra labels to build up the labels

/// For typedef, constants, and statics
const BASE_CONST: &[&str] = &[label_strs::type_of];
const BASE_CONST: &[&str] = &[label_strs::try_type_of];

/// DepNodes for functions + methods
const BASE_FN: &[&str] = &[
// Callers will depend on the signature of these items, so we better test
label_strs::fn_sig,
label_strs::try_fn_sig,
label_strs::generics_of,
label_strs::predicates_of,
label_strs::type_of,
label_strs::try_type_of,
// And a big part of compilation (that we eventually want to cache) is type inference
// information:
label_strs::typeck,
Expand All @@ -71,7 +71,7 @@ const BASE_MIR: &[&str] = &[label_strs::optimized_mir, label_strs::promoted_mir]
/// Note that changing the type of a field does not change the type of the struct or enum, but
/// adding/removing fields or changing a fields name or visibility does.
const BASE_STRUCT: &[&str] =
&[label_strs::generics_of, label_strs::predicates_of, label_strs::type_of];
&[label_strs::generics_of, label_strs::predicates_of, label_strs::try_type_of];

/// Trait definition `DepNode`s.
const BASE_TRAIT_DEF: &[&str] = &[
Expand Down
4 changes: 2 additions & 2 deletions compiler/rustc_metadata/src/rmeta/decoder/cstore_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl IntoArgs for (CrateNum, DefId) {
}

provide! { <'tcx> tcx, def_id, other, cdata,
type_of => { cdata.get_type(def_id.index, tcx) }
try_type_of => { Ok(cdata.get_type(def_id.index, tcx)) }
generics_of => { cdata.get_generics(def_id.index, tcx.sess) }
explicit_predicates_of => { cdata.get_explicit_predicates(def_id.index, tcx) }
inferred_outlives_of => { cdata.get_inferred_outlives(def_id.index, tcx) }
Expand Down Expand Up @@ -123,7 +123,7 @@ provide! { <'tcx> tcx, def_id, other, cdata,
mir_abstract_const => { cdata.get_mir_abstract_const(tcx, def_id.index) }
unused_generic_params => { cdata.get_unused_generic_params(def_id.index) }
mir_const_qualif => { cdata.mir_const_qualif(def_id.index) }
fn_sig => { cdata.fn_sig(def_id.index, tcx) }
try_fn_sig => { Ok(cdata.fn_sig(def_id.index, tcx)) }
inherent_impls => { cdata.get_inherent_implementations_for_type(tcx, def_id.index) }
is_const_fn_raw => { cdata.is_const_fn_raw(def_id.index) }
asyncness => { cdata.asyncness(def_id.index) }
Expand Down
Loading