Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow references to interior mutable data behind a feature gate #80418

Merged
merged 13 commits into from
Jan 4, 2021
Merged

Allow references to interior mutable data behind a feature gate #80418

merged 13 commits into from
Jan 4, 2021

Commits on Jan 1, 2021

  1. Allow references to interior mutable data behind a feature gate

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    0b84184 View commit details
    Browse the repository at this point in the history

  2. The proper name for the rule is "enclosing scope"

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    3a44a20 View commit details
    Browse the repository at this point in the history

  3. Fix cell checks in const fn

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    354e510 View commit details
    Browse the repository at this point in the history

  4. Enhance some comments

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    4158e58 View commit details
    Browse the repository at this point in the history

  5. Reinstate the error-code error over the feature gate error

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    3ed1403 View commit details
    Browse the repository at this point in the history

  6. Don't mix feature gates and hard errors, decide on one per op and sti… 

    …ck with it
    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    aaee3f2 View commit details
    Browse the repository at this point in the history

  7. Bless ui tests

    @oli-obk
    oli-obk committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    ba3a876 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2021

  1. Apply suggestions from code review 

    comment nits

Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    e5330a4 View commit details
    Browse the repository at this point in the history

  2. Update now-more-precise operation with a preciser message

    @oli-obk
    oli-obk committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    a137ff1 View commit details
    Browse the repository at this point in the history

  3. Grammar fixes 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung authored Jan 3, 2021
    Configuration menu
    Copy the full SHA
    e5e4a85 View commit details
    Browse the repository at this point in the history

  4. Dangling pointers point to everything and nothing 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung authored Jan 3, 2021
    Configuration menu
    Copy the full SHA
    8968c8a View commit details
    Browse the repository at this point in the history

  5. Refactor the non-transient cell borrow error diagnostic

    @oli-obk
    oli-obk committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    d3992f3 View commit details
    Browse the repository at this point in the history

  6. Stylistic fixes to diagnostic messages

    @oli-obk
    oli-obk committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    90b56b9 View commit details
    Browse the repository at this point in the history