-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent no_prelude attribute #80427
Consistent no_prelude attribute #80427
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @alexcrichton since you reviewed the last PR |
☔ The latest upstream changes (presumably #80530) made this pull request unmergeable. Please resolve the merge conflicts. |
The PR is from 2016 and the RFC is from 2014, the whole idea should probably be revised before proceeding. In recent years |
☔ The latest upstream changes (presumably #80459) made this pull request unmergeable. Please resolve the merge conflicts. |
Er sorry I don't really remember the context of a PR I reviewed 5 (!) years ago at this point. I'm probably not the best reviewer for this. Would you be ok selecting a different reviewer? r? @oli-obk |
☔ The latest upstream changes (presumably #80425) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #80867) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #80782) made this pull request unmergeable. Please resolve the merge conflicts. |
I have no real knowledge of this area, but I agree that just the existance of an RFC does not motivate the change, and I'm not sure the original motivation still applies (considering that there was no activity on the tracking issue for years). cc @Kimundi @Nemo157 how do you feel about abolishing this scheme entirely and coming up with something new that does not conflict with macro imports? |
☔ The latest upstream changes (presumably #81113) made this pull request unmergeable. Please resolve the merge conflicts. |
move no-prelude tests to tests/ui remove duplicate no-implicit-prelude tests
so that #![no_prelude] is not marked as used when it is implied by #![no_implicit_prelude]
Rebases and adjusts the work of the inactive pr #32025 for rust-lang/rfcs#501
with tracking issue #20561
From the original PR:
This version does not deprecate
no_implicit_prelude
as this appears to be the consent of the discussion of the original pr.