Rollup of 10 pull requests #80436

Dylan-DPC-zz · 2020-12-28T12:36:53Z

Successful merges:

Move some more code out of CodegenBackend::{codegen_crate,link} #79662 (Move some more code out of CodegenBackend::{codegen_crate,link})
Lint on redundant trailing semicolon after item #79812 (Lint on redundant trailing semicolon after item)
Update RELEASES.md for 1.49.0 #79815 (Update RELEASES.md for 1.49.0)
Suggest fn ptr rather than fn item and suggest to use Fn trait bounds rather than the unique closure type in E0121 #80284 (Suggest fn ptr rather than fn item and suggest to use Fn trait bounds rather than the unique closure type in E0121)
Add more comments to trait queries #80331 (Add more comments to trait queries)
use matches!() macro in more places #80344 (use matches!() macro in more places)
BTreeMap: test split_off (and append) more thoroughly #80353 (BTreeMap: test split_off (and append) more thoroughly)
Document rustc_macros on nightly-rustc #80362 (Document rustc_macros on nightly-rustc)
Remove FIXME in rustc_privacy #80399 (Remove FIXME in rustc_privacy)
Sync rustc_codegen_cranelift #80408 (Sync rustc_codegen_cranelift)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…clif-2020-11-27

Complement to rust-lang#78863

This includes bytecodealliance/wasmtime#2403 which enables hotswapping with SimpleJIT

We now lint on code like this: ```rust fn main() { fn foo() {}; struct Bar {}; } ``` Previously, this caused warnings in Cargo, so it was disabled.

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

This can happen in generic code

Directly use raw pointers in `AtomicPtr` store/load I was unable to find any reason for this limitation in the latest source of LLVM or in the documentation [here](http://llvm.org/docs/Atomics.html#libcalls-atomic). fixes rust-lang/miri#1574

LICM in Cranelift has been fixed recently

This commit makes minor changes to the cranelift backend so that it can build given changes in cg_ssa for Split DWARF. Signed-off-by: David Wood <david@davidtw.co>

…omatsakis Move binder for dyn to each list item This essentially changes `ty::Binder<&'tcx List<ExistentialTraitRef>>` to `&'tcx List<ty::Binder<ExistentialTraitRef>>`. This is a first step in moving the `dyn Trait` representation closer to Chalk, which we've talked about in `@rust-lang/wg-traits.` r? `@nikomatsakis`

Lazy compilation has the potential to significantly improve the startup time of a program. While functions have to be codegened when called, it is expected that a significant amount of all code is only required when an error occurs or only when the program is used in certain ways. The basic approach is to first codegen a shim for each function. This shim calls the `__cg_clif_jit` function of cg_clif with a pointer to the `Instance` corresponding to the function for which it is a shim. `__cg_clif_jit` function then codegens this function and uses the hot code swapping support of SimpleJIT to redirect future calls to the function to the real version. Finally it calls the newly codegened function.

Lazy compilation in jit mode

…clif-2020-12-27

…n_backend, r=oli-obk Move some more code out of CodegenBackend::{codegen_crate,link} Kind of a follow up to rust-lang#77795

…r=oli-obk Lint on redundant trailing semicolon after item We now lint on code like this: ```rust fn main() { fn foo() {}; struct Bar {}; } ``` Previously, this caused warnings in Cargo, so it was disabled.

…Simulacrum Update RELEASES.md for 1.49.0 ### [Rendered](https://github.com/XAMPPRocky/rust/tree/relnotes-1.49.0/RELEASES.md) r? `@Mark-Simulacrum` cc `@rust-lang/release`

…arkor Suggest fn ptr rather than fn item and suggest to use `Fn` trait bounds rather than the unique closure type in E0121 Previously, using `_` as a return type in a function that returned a function/closure would provide a diagnostic that would cause a papercut. For example: ```rust fn f() -> i32 { 0 } fn fn_ptr() -> _ { f } fn closure() -> _ { || 0 } ``` would result in this diagnostic: ```rust error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> <anon>:2:16 | 2 | fn fn_ptr() -> _ { f } | ^ | | | not allowed in type signatures | help: replace with the correct return type: `fn() -> i32 {f}` error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> <anon>:3:17 | 3 | fn closure() -> _ { || 0 } | ^ | | | not allowed in type signatures | help: replace with the correct return type: `[closure@<anon>:3:21: 3:25]` error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0121`. ``` As can be seen, it was suggested to use the function definition return type `fn() -> i32 { f }` which is not valid syntax as a return type. Additionally, closures cause a papercut as unique closure types (notated in this case as `[closure@<anon>:3:21: 3:25]`) are not valid syntax either. Instead, this PR implements this version of the diagnostic (this example is for the same code featured above): ```rust error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> <anon>:2:16 | 2 | fn fn_ptr() -> _ { f } | ^ | | | not allowed in type signatures | help: replace with the correct return type: `fn() -> i32` error[E0121]: the type placeholder `_` is not allowed within types on item signatures --> <anon>:3:17 | 3 | fn closure() -> _ { || 0 } | ^ not allowed in type signatures | = help: consider using an `Fn`, `FnMut`, or `FnOnce` trait bound = note: for more information on `Fn` traits and closure types, see https://doc.rust-lang.org/book/ch13-01-closures.html error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0121`. ``` As can be seen in this diagnostic, the papercut for returning a function item is fixed by suggesting the usage of a function pointer as the return type. As for closures, it's suggested to use an `Fn`, `FnMut`, or `FnOnce` trait bound (with further reading on closures and `Fn` traits in *The Book* for beginners). I did not implement a suggestion to use `impl Fn() -> i32` syntax as that was out-of-scope for my abilities at the moment, therefore someone in the future may want to implement that. Also, it's possible to use either `impl Trait` syntax, generics, or generics with a `where` clause, and some users may not want to use `impl Trait` syntax for their own reasons. This PR fixes rust-lang#80179.

Add more comments to trait queries This also adds back a comment that was mistakenly removed in ac9dfc3.

use matches!() macro in more places

…k-Simulacrum BTreeMap: test split_off (and append) more thoroughly Using DeterministicRng as a poor man's property based testing rig. r? `@Mark-Simulacrum`

Document rustc_macros on nightly-rustc Fixes rust-lang#80345. ![image](https://user-images.githubusercontent.com/23638587/103113442-b7ba2d00-4628-11eb-8a4d-c542f2d170e1.png) ![image](https://user-images.githubusercontent.com/23638587/103113448-bc7ee100-4628-11eb-8657-2d72e88de656.png) r? `@ehuss`

Remove FIXME in rustc_privacy rust-lang#71104 has been fixed. r? `@marmeladema` if you have time, otherwise `@petrochenkov`

…jorn3 Sync rustc_codegen_cranelift The highlight of this sync are two JIT mode improvements. The first is that it is now possible to use JIT mode when using `-Zcodegen-backend` instead of the custom driver using `-Cllvm-args=mode=jit`. The second one is a new JIT mode that lazily compiles functions when they are called the first time: https://github.com/bjorn3/rustc_codegen_cranelift/pull/1120 In addition this includes a few small runtime performance improvements and various fixes for rustc changes that didn't cause compilation to fail. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler

Dylan-DPC-zz · 2020-12-28T12:37:33Z

@bors r+ rollup=never p=5

bors · 2020-12-28T12:37:34Z

📌 Commit d3409f8 has been approved by Dylan-DPC

rust-log-analyzer · 2020-12-28T13:00:36Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 9000/11196
.................................................................................................... 9100/11196
......................................................................................i......i...... 9200/11196
.................................................................................................... 9300/11196
.........................iiiiii..iiiiii.i........................................................... 9400/11196
.................................................................................................... 9600/11196
.................................................................................................... 9700/11196
.................................................................................................... 9800/11196
.................................................................................................... 9900/11196
---
Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 27 tests
iiiiiiiiiiiiiiiiiiiiiiiiiii

 finished in 0.066 seconds
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 116 tests
iiiiiiiiii.i.i..i..i..ii....i.i....ii...........iiii.........i....i...i.......ii.i.ii.....iiii.....i 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.31s

 finished in 2.376 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---

   Doc-tests alloc

running 528 tests
FFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF 100/528
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF 200/528
FFFFFFFFFFFFFFFFFFFFFFiFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFF 300/528
F..FFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.FFFF.FFFFFFFFFFFFFFFFFFFFFFF 400/528
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF 500/528
failures:

---- src/boxed.rs - boxed (line 12) stdout ----
error: unnecessary trailing semicolon
error: unnecessary trailing semicolon
 --> src/boxed.rs:15:2
  |
6 | }; _doctest_main_src_boxed_rs_12_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:11:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed (line 97) stdout ----
---- src/boxed.rs - boxed (line 97) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:110:2
   |
16 | }; _doctest_main_src_boxed_rs_97_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:96:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed (line 19) stdout ----
---- src/boxed.rs - boxed (line 19) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:22:2
  |
6 | }; _doctest_main_src_boxed_rs_19_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:18:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::ToOwned::to_owned (line 46) stdout ----
---- src/borrow.rs - borrow::ToOwned::to_owned (line 46) stdout ----
error: unnecessary trailing semicolon
 --> src/borrow.rs:52:2
  |
9 | }; _doctest_main_src_borrow_rs_46_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/borrow.rs:45:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/alloc.rs - alloc::alloc (line 70) stdout ----
---- src/alloc.rs - alloc::alloc (line 70) stdout ----
error: unnecessary trailing semicolon
  --> src/alloc.rs:82:2
   |
15 | }; _doctest_main_src_alloc_rs_70_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/alloc.rs:69:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow::into_owned (line 288) stdout ----
---- src/borrow.rs - borrow::Cow::into_owned (line 288) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:298:2
   |
13 | }; _doctest_main_src_borrow_rs_288_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:287:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/alloc.rs - alloc::alloc_zeroed (line 140) stdout ----
---- src/alloc.rs - alloc::alloc_zeroed (line 140) stdout ----
error: unnecessary trailing semicolon
  --> src/alloc.rs:151:2
   |
14 | }; _doctest_main_src_alloc_rs_140_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/alloc.rs:139:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow::to_mut (line 254) stdout ----
---- src/borrow.rs - borrow::Cow::to_mut (line 254) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:264:2
   |
13 | }; _doctest_main_src_borrow_rs_254_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:253:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow::is_owned (line 232) stdout ----
---- src/borrow.rs - borrow::Cow::is_owned (line 232) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:241:2
   |
12 | }; _doctest_main_src_borrow_rs_232_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:231:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow::into_owned (line 302) stdout ----
---- src/borrow.rs - borrow::Cow::into_owned (line 302) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:312:2
   |
13 | }; _doctest_main_src_borrow_rs_302_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:301:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::ToOwned::clone_into (line 65) stdout ----
---- src/borrow.rs - borrow::ToOwned::clone_into (line 65) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:72:2
   |
10 | }; _doctest_main_src_borrow_rs_65_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:64:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed (line 26) stdout ----
---- src/boxed.rs - boxed (line 26) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:35:2
   |
12 | }; _doctest_main_src_boxed_rs_26_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:25:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow::is_borrowed (line 209) stdout ----
---- src/borrow.rs - borrow::Cow::is_borrowed (line 209) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:218:2
   |
12 | }; _doctest_main_src_borrow_rs_209_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:208:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow (line 108) stdout ----
---- src/borrow.rs - borrow::Cow (line 108) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:134:2
   |
29 | }; _doctest_main_src_borrow_rs_108_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:107:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::from_raw_in (line 599) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::from_raw_in (line 599) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:607:2
   |
11 | }; _doctest_main_src_boxed_rs_599_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:598:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<Any, A>::downcast (line 1158) stdout ----
---- src/boxed.rs - boxed::Box<Any, A>::downcast (line 1158) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:1170:2
   |
15 | }; _doctest_main_src_boxed_rs_1158_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:1157:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<Any + Send, A>::downcast (line 1190) stdout ----
---- src/boxed.rs - boxed::Box<Any + Send, A>::downcast (line 1190) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:1202:2
   |
15 | }; _doctest_main_src_boxed_rs_1190_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:1189:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::into_raw_with_allocator (line 697) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::into_raw_with_allocator (line 697) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:705:2
   |
11 | }; _doctest_main_src_boxed_rs_697_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:696:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::into_raw (line 652) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::into_raw (line 652) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:656:2
  |
7 | }; _doctest_main_src_boxed_rs_652_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:651:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::into_raw (line 659) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::into_raw (line 659) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:669:2
   |
13 | }; _doctest_main_src_boxed_rs_659_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:658:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/borrow.rs - borrow::Cow (line 138) stdout ----
---- src/borrow.rs - borrow::Cow (line 138) stdout ----
error: unnecessary trailing semicolon
  --> src/borrow.rs:169:2
   |
34 | }; _doctest_main_src_borrow_rs_138_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/borrow.rs:137:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::from_raw_in (line 609) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::from_raw_in (line 609) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:623:2
   |
17 | }; _doctest_main_src_boxed_rs_609_0().unwrap() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:608:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::clone_from (line 875) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::clone_from (line 875) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:887:2
   |
15 | }; _doctest_main_src_boxed_rs_875_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:874:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::into_raw_with_allocator (line 708) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::into_raw_with_allocator (line 708) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:721:2
   |
16 | }; _doctest_main_src_boxed_rs_708_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:707:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::new_in (line 253) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::new_in (line 253) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:259:2
  |
9 | }; _doctest_main_src_boxed_rs_253_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:252:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T, A>::leak (line 779) stdout ----
---- src/boxed.rs - boxed::Box<T, A>::leak (line 779) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:784:2
  |
8 | }; _doctest_main_src_boxed_rs_779_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:778:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T>::new (line 180) stdout ----
---- src/boxed.rs - boxed::Box<T>::new (line 180) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:182:2
  |
5 | }; _doctest_main_src_boxed_rs_180_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:179:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T>::from_raw (line 551) stdout ----
---- src/boxed.rs - boxed::Box<T>::from_raw (line 551) stdout ----
error: unnecessary trailing semicolon
 --> src/boxed.rs:555:2
  |
7 | }; _doctest_main_src_boxed_rs_551_0() }
  |  ^ help: remove this semicolon
note: the lint level is defined here
 --> src/boxed.rs:550:9
  |
2 | #![deny(warnings)]
2 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: `#[deny(redundant_semicolons)]` implied by `#[deny(warnings)]`
error: aborting due to previous error

Couldn't compile the test.
---- src/boxed.rs - boxed::Box<T>::from_raw (line 557) stdout ----
---- src/boxed.rs - boxed::Box<T>::from_raw (line 557) stdout ----
error: unnecessary trailing semicolon
  --> src/boxed.rs:568:2
   |
14 | }; _doctest_main_src_boxed_rs_557_0() }
   |  ^ help: remove this semicolon
note: the lint level is defined here
  --> src/boxed.rs:556:9
   |
2  | #![deny(warnings)]
2  | #![deny(warnings)]
   |         ^^^^^^^^
---
test result: FAILED. 9 passed; 518 failed; 1 ignored; 0 measured; 0 filtered out; finished in 2.60s



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "-p" "alloc" "--" "--quiet"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:21:06

bjorn3 and others added 30 commits November 27, 2020 20:48

Merge commit '5988bbd24aa87732bfa1d111ba00bcdaa22c481a' into sync_cg_…

d404840

…clif-2020-11-27

Sync from rust 760430e

3d357e6

Allow cranelift to handle atomic pointers

7760894

Rustup to rustc 1.50.0-nightly (f4db9ff 2020-12-02)

a8cda1a

Update Cranelift

64e7ff2

Support #[repr(simd)] on array wrappers

d95d03a

Complement to rust-lang#78863

Update Cranelift

3f28a49

This includes bytecodealliance/wasmtime#2403 which enables hotswapping with SimpleJIT

Inline codegen_mono_item

5f21ff2

Lint on redundant trailing semicolon after item

6ada445

We now lint on code like this: ```rust fn main() { fn foo() {}; struct Bar {}; } ``` Previously, this caused warnings in Cargo, so it was disabled.

Update RELEASES.md for 1.49.0

8913419

Remove trailing semicolon in librustdoc

fdc336c

Apply suggestions from code review

7bb1889

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>

Update RELEASES.md

468c578

Update RELEASES.md

edb55e9

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

Update RELEASES.md

4aaace9

Optimize branches when the target is statically known to a jump

994b91a

This can happen in generic code

Move binder for dyn to each list item

42b267d

Update Cranelift

f8e22bf

Enable Cranelift optimizations when optimizing

3f47f93

LICM in Cranelift has been fixed recently

Update RELEASES.md

bb6b6ae

Fix Cranelift link in readme (rust-lang#1118)

cd21269

Also emit vcode when emitting clif ir while using new style backends

44b3310

cg_clif: fix build with split dwarf

5f6c32a

This commit makes minor changes to the cranelift backend so that it can build given changes in cg_ssa for Split DWARF. Signed-off-by: David Wood <david@davidtw.co>

Move some code out of CodegenBackend::{codegen_crate,link}

2c0dccb

Fix tests

3a3a23f

Sync from rust caeb333

0f57e1c

Rustup to rustc 1.50.0-nightly (b32e6e6 2020-12-16)

8e234d5

Sync from rust fee693d

06e77b9

matthiaskrgr and others added 23 commits December 24, 2020 13:35

use matches!() macro in more places

d12a358

BTreeMap: test split_off (and append) more thoroughly

d473cbe

Document rustc_macros on nightly-rustc

82acbc8

Use PIC in JIT mode too

c556e4d

Change the way JIT mode is selected

20ffea6

Move finalize CodegenCx timer out of codegen mono items timer

0b9b253

Add documentation

35f4a25

Merge pull request rust-lang#1120 from bjorn3/lazy_jit

2ca8daa

Lazy compilation in jit mode

Set rust-analyzer importMergeBehaviour option to last

5b32489

Rustfmt

dbee136

Remove FIXME in rustc_privacy

53da233

Merge commit 'dbee13661efa269cb4cd57bb4c6b99a19732b484' into sync_cg_…

52cf01c

…clif-2020-12-27

Rollup merge of rust-lang#79662 - bjorn3:move_more_code_out_of_codege…

58aefbd

…n_backend, r=oli-obk Move some more code out of CodegenBackend::{codegen_crate,link} Kind of a follow up to rust-lang#77795

Rollup merge of rust-lang#79812 - Aaron1011:lint-item-trailing-semi, …

761400f

…r=oli-obk Lint on redundant trailing semicolon after item We now lint on code like this: ```rust fn main() { fn foo() {}; struct Bar {}; } ``` Previously, this caused warnings in Cargo, so it was disabled.

Rollup merge of rust-lang#79815 - XAMPPRocky:relnotes-1.49.0, r=Mark-…

549b591

…Simulacrum Update RELEASES.md for 1.49.0 ### [Rendered](https://github.com/XAMPPRocky/rust/tree/relnotes-1.49.0/RELEASES.md) r? `@Mark-Simulacrum` cc `@rust-lang/release`

Rollup merge of rust-lang#80331 - jyn514:docs, r=varkor

80bf28e

Add more comments to trait queries This also adds back a comment that was mistakenly removed in ac9dfc3.

Rollup merge of rust-lang#80344 - matthiaskrgr:matches, r=Dylan-DPC

14c42d8

use matches!() macro in more places

Rollup merge of rust-lang#80353 - ssomers:btree_test_split_off, r=Mar…

2660e04

…k-Simulacrum BTreeMap: test split_off (and append) more thoroughly Using DeterministicRng as a poor man's property based testing rig. r? `@Mark-Simulacrum`

Rollup merge of rust-lang#80399 - jyn514:hir-id-cleanup, r=marmeladema

1a18fb4

Remove FIXME in rustc_privacy rust-lang#71104 has been fixed. r? `@marmeladema` if you have time, otherwise `@petrochenkov`

rustbot added the rollup A PR which is a rollup label Dec 28, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 28, 2020

Dylan-DPC-zz mentioned this pull request Dec 28, 2020

Lint on redundant trailing semicolon after item #79812

Merged

Dylan-DPC-zz closed this Dec 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #80436

Rollup of 10 pull requests #80436

Dylan-DPC-zz commented Dec 28, 2020

Dylan-DPC-zz commented Dec 28, 2020

bors commented Dec 28, 2020

rust-log-analyzer commented Dec 28, 2020

Rollup of 10 pull requests #80436

Rollup of 10 pull requests #80436

Conversation

Dylan-DPC-zz commented Dec 28, 2020

Dylan-DPC-zz commented Dec 28, 2020

bors commented Dec 28, 2020

rust-log-analyzer commented Dec 28, 2020