-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bool
and !
docs
#80590
Update bool
and !
docs
#80590
Conversation
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
/// important macro in testing, checks whether an expression is `true` and panics | ||
/// if it isn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could reword
checks whether an expression is
true
and panics if it isn't.
as
panics if the expression is
false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting
checks whether an expression is
true
and panics if it'sfalse
or something else? I feel like maybe it's good enough as it is now, but open to changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankfully Rust isn’t Haskell and doesn’t have to worry about pervasive bottoms in data, so it really is the case for us that “isn’t true
” necessarily implies “is false
”. 😄
r=me your call if you want to apply the comments. |
@bors r+ rollup |
📌 Commit 4e76759 has been approved by |
☀️ Test successful - checks-actions |
No description provided.