Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bool and ! docs #80590

Merged
merged 2 commits into from
Jan 3, 2021
Merged

Update bool and ! docs #80590

merged 2 commits into from
Jan 3, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Jan 1, 2021

No description provided.

@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-lang Relevant to the language team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jan 1, 2021
@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2021
Comment on lines +15 to +16
/// important macro in testing, checks whether an expression is `true` and panics
/// if it isn't.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could reword

checks whether an expression is true and panics if it isn't.

as

panics if the expression is false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting

checks whether an expression is true and panics if it's false

or something else? I feel like maybe it's good enough as it is now, but open to changing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully Rust isn’t Haskell and doesn’t have to worry about pervasive bottoms in data, so it really is the case for us that “isn’t true” necessarily implies “is false”. 😄

@nagisa
Copy link
Member

nagisa commented Jan 2, 2021

r=me your call if you want to apply the comments.

@nagisa
Copy link
Member

nagisa commented Jan 2, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 2, 2021

📌 Commit 4e76759 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2021
@bors
Copy link
Collaborator

bors commented Jan 3, 2021

⌛ Testing commit 4e76759 with merge bcd6975...

@bors
Copy link
Collaborator

bors commented Jan 3, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing bcd6975 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2021
@bors bors merged commit bcd6975 into rust-lang:master Jan 3, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 3, 2021
@camelid camelid deleted the bool-never-docs branch January 3, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants