Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #80615

Merged
merged 13 commits into from
Jan 2, 2021
Merged

Rollup of 6 pull requests #80615

merged 13 commits into from
Jan 2, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jan 2, 2021

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

m-ou-se and others added 13 commits December 31, 2020 13:52
fixes clippy warnings of type:
match_like_matches_macro
or_fun_call
op_ref
needless_return
let_and_return
single_char_add_str
useless_format
unnecessary_sort_by
match_ref_pats
redundant_field_names
So that at least it won't ICE for users whether or not they enable the gate. For developers the FIXMEs are enough.
clippy fixes for librustdoc

fixes clippy warnings of type:
match_like_matches_macro
or_fun_call
op_ref
needless_return
let_and_return
single_char_add_str
useless_format
unnecessary_sort_by
match_ref_pats
redundant_field_names
…drAus

Improve library tracking issue template

r? `@KodrAus`
…lacrum

Clean bootstrap artifacts on `x.py clean`

Closes rust-lang#76519

r? `@Mark-Simulacrum`
…lcnr

improve unconditional_panic description

The fact that the lint is triggered by the ConstProp pass is an implementation detail, I do not think that this should be mentioned in the description.

Cc `@oli-obk` `@ehuss`
`const_generics_defaults`: don't ICE in the unimplemented parts

The thought was that we could use `todo!`s to ensure we wouldn't forget to implement parts of the experimental gate.

However, that can also lead to a suboptimal experience for users as shown in rust-lang#80589 having both the error/warning about the experimental feature, and the ICE.

Fixes rust-lang#80589

r? `@varkor`
Diag: print enum variant instead of enum type

Closes rust-lang#80607
@rustbot rustbot added the rollup A PR which is a rollup label Jan 2, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 2, 2021

@bors r+ p=6 rollup=never

@bors
Copy link
Contributor

bors commented Jan 2, 2021

📌 Commit 4172756 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 2, 2021
@bors
Copy link
Contributor

bors commented Jan 2, 2021

⌛ Testing commit 4172756 with merge 90ccf4f...

@bors
Copy link
Contributor

bors commented Jan 2, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 90ccf4f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2021
@bors bors merged commit 90ccf4f into rust-lang:master Jan 2, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants