-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PredicateKind and instead only use Binder<PredicateAtom> #80679
Conversation
The job Click to see the possible cause of the failure (guessed by this bot)
|
fc5d288
to
84d04e3
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's still some cleanup to do, but the changes look promising to me.
I do want @nikomatsakis to take a quick look here. Do you mind writing a short MCP for this?
The job Click to see the possible cause of the failure (guessed by this bot)
|
53dcc81
to
9d576a8
Compare
#73503 had a slight perf regression and this does decrease the size of @bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit 9d576a88e2601faffad5957dcad230bc42c23b2f with merge 030cb70ea034a6fb30a1e496542752e37585c946... |
☀️ Try build successful - checks-actions |
Queued 030cb70ea034a6fb30a1e496542752e37585c946 with parent 9a22f99, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (030cb70ea034a6fb30a1e496542752e37585c946): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
This does seem to basically revert the perf changes seen in ##73503 |
The job Click to see the possible cause of the failure (guessed by this bot)
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
e572047
to
ad957ab
Compare
☔ The latest upstream changes (presumably #80499) made this pull request unmergeable. Please resolve the merge conflicts. |
ad957ab
to
2e37ee0
Compare
☔ The latest upstream changes (presumably #79328) made this pull request unmergeable. Please resolve the merge conflicts. |
⌛ Trying commit c76f478 with merge 87554a65d9da075171df1642c8b1708dd8782a8e... |
☀️ Try build successful - checks-actions |
Queued 87554a65d9da075171df1642c8b1708dd8782a8e with parent 49d7889, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (87554a65d9da075171df1642c8b1708dd8782a8e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
r=me after that, perf looks good enough |
@bors delegate=jackh726 |
✌️ @jackh726 can now approve this pull request |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors r=lcnr |
📌 Commit c4376ba has been approved by |
☀️ Test successful - checks-actions |
Remove PredicateKind and instead only use Binder<PredicateAtom> Originally brought up in rust-lang#76814 (comment) r? `@lcnr`
Originally brought up in #76814 (comment)
r? @lcnr