Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rustdoc::clean::utils::find_nearest_parent_module to TyCtxt #80740

Closed
wants to merge 2 commits into from
Closed

Move rustdoc::clean::utils::find_nearest_parent_module to TyCtxt #80740

wants to merge 2 commits into from

Commits on Jan 6, 2021

  1. Move rustdoc::clean::utils::find_nearest_parent_module to TyCtxt 

    `find_nearest_parent_module` was extracted from
`rustdoc::passes::collect_intra_doc_links` in rust-lang#80368.

We (me and Joshua Nelson) thought at the time that it should be in rustc
instead, and Joshua suggested it be a method on `TyCtxt`.
However, since rust-lang#80368 was fixing a significant regression that was about
to land on beta, we agreed that to be able to fix this quickly I should
leave the code in rustdoc.

This is a followup PR to move it to `TyCtxt`.
    @camelid
    camelid committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    859a707 View commit details
    Browse the repository at this point in the history

  2. Remove comment about rustdoc usage 

    In general it's assumed that compiler APIs may panic on fake IDs.
    @camelid
    camelid committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a1c4b55 View commit details
    Browse the repository at this point in the history