Get rid of custom pretty-printing in rustdoc #80799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
and use rustc_hir_pretty directly instead
jyn514
added
the
S-waiting-on-review
|
This looks good to me. I don't think I actually have r+ rights, but this is what I imagined the best solution would be. |
|
Thanks :) @bors r=CraftSpider |
|
📌 Commit 31375d2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#79675 (Make sure rust-call errors occur correctly for traits) - rust-lang#80372 (Don't panic when an external crate can't be resolved) - rust-lang#80761 (handle generic trait methods in coverage-report tests) - rust-lang#80785 (rustc_ast_pretty: Remove `PrintState::insert_extra_parens`) - rust-lang#80791 (Fix type name in doc example for Iter and IterMut) - rust-lang#80794 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) - rust-lang#80799 (Get rid of custom pretty-printing in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 12, 2021
…melid Don't display `mut` in arguments for functions documentation Fixes rust-lang#81289 by reverting rust-lang#80799, as requested in rust-lang#81328 (comment). Supersedes rust-lang#81328. r? `@camelid` cc `@jyn514`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 12, 2021
…melid Don't display `mut` in arguments for functions documentation Fixes rust-lang#81289 by reverting rust-lang#80799, as requested in rust-lang#81328 (comment). Supersedes rust-lang#81328. r? ``@camelid`` cc ``@jyn514``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use rustc_hir_pretty directly instead.
Closes #79497.
r? @CraftSpider