Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Update cargo #80975

Merged
merged 1 commit into from
Jan 14, 2021
Merged

[beta] Update cargo #80975

merged 1 commit into from
Jan 14, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 13, 2021

1 commits in 75d5d8cffe3464631f82dcd3c470b78dc1dda8bb..1a8df6a5196e4cad9a3956867e7e928f2bfaaba4
2020-12-22 18:10:56 +0000 to 2021-01-12 20:10:42 +0000

@rust-highfive
Copy link
Collaborator

Updates src/tools/cargo.

cc @ehuss

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2021
@ehuss ehuss added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 13, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

(Was there some reason you didn't self-approve this change?)

@bors
Copy link
Contributor

bors commented Jan 13, 2021

📌 Commit 914bed4 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Jan 13, 2021

(Was there some reason you didn't self-approve this change?)

I thought you usually like to roll up beta backports periodically instead of trickling them through via individual PRs. If you want, I can self-approve beta PRs in the future?

@Mark-Simulacrum
Copy link
Member

I want to, but submodule bumps are sometimes a pain there, so easier to land those separately.

Realistically the reason is it's much easier to cherry pick things already landed somewhere in rust-lang/rust and this wouldn't be

@bors
Copy link
Contributor

bors commented Jan 14, 2021

⌛ Testing commit 914bed4 with merge ea20aa2...

@bors
Copy link
Contributor

bors commented Jan 14, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ea20aa2 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2021
@bors bors merged commit ea20aa2 into rust-lang:beta Jan 14, 2021
@rustbot rustbot added this to the 1.50.0 milestone Jan 14, 2021
@Mark-Simulacrum Mark-Simulacrum removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @rustbot