Don't ICE when computing a layout of a generator tainted by errors #81008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Fixes #80998, presumably |
|
Thanks! @bors r+ rollup |
|
📌 Commit 5ea1d0e has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 15, 2021
…ndry Don't ICE when computing a layout of a generator tainted by errors Fixes rust-lang#80998.
hellow554
reviewed
Jan 15, 2021
|
|
||
| type F = impl Future; | ||
| // Check that statics are inhabited computes they layout. | ||
| static POOL: Task<F> = Task::new(); |
There was a problem hiding this comment.
there should be a second error here, that Task::new isn't const and therefore can't be used in a static expression, right?
There was a problem hiding this comment.
This check is skipped if there are type errors, so it will only appear only after resolving the first error.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#80254 (Don't try to add nested predicate to Rustdoc auto-trait `ParamEnv`) - rust-lang#80834 (Remove unreachable panics from VecDeque::{front/back}[_mut]) - rust-lang#80944 (Use Option::map_or instead of `.map(..).unwrap_or(..)`) - rust-lang#81008 (Don't ICE when computing a layout of a generator tainted by errors) - rust-lang#81023 (Remove doctree::Variant) Failed merges: - rust-lang#81033 (Remove useless `clean::Variant` struct) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80998.