-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #81057
Merged
Merged
Rollup of 6 pull requests #81057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had exactly one field and no special behavior, so there was no point.
There's no `Variant`, so it seems silly to have `Kind`.
Add test for rust-lang#59352 Issue rust-lang#59352 reported an optimization regression with rustc 1.32.0+. That regression could be tracked to a change that caused a function to miss the size limit of llvm's inlining, which results in an unreachable panicing branch being generated. Enabling mir inline solves the issue, but is currently only done for `mir-opt-level>=2`. This PR adds a test that can serve as a regression test for rust-lang#59352, if/when mir inlining gets mature enough for opt-level 1, or some other optimization can remove the panic.
…Nemo157,jyn514 Improve JS performance by storing length before comparing to it in loops Since rust-lang#79052 is quite complicated to review, I suggested to split into smaller parts. This first part is mostly about saving the array length into a variable (I tried to not change anything else as much as possible 😃 ). r? `@jyn514`
Update mdbook Just a few small fixes and changes, see https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-046 for a list.
Remove useless `clean::Variant` struct It had exactly one field and no special behavior, so there was no point in having it. r? `@CraftSpider`
inline: Round word-size cost estimates up
Drop a few unneeded borrows `@rustbot` modify labels +C-cleanup +T-compiler
@bors: r+ p=6 |
📌 Commit f8b1baa has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jan 15, 2021
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
clean::Variant
struct #81033 (Remove uselessclean::Variant
struct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup