Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable all num tests on WASM #81058

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Re-enable all num tests on WASM #81058

merged 1 commit into from
Jan 17, 2021

Conversation

syvb
Copy link
Contributor

@syvb syvb commented Jan 15, 2021 •
edited by Mark-Simulacrum
Loading

This was partially done by #47365, but a few tests were missed in that PR.

@syvb
Re-enable all num tests on WASM
e10555c 
This was partially done by rust-lang#47365, but a few tests
were missed in that PR.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2021
@Mark-Simulacrum
Copy link
Member

Thanks!

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jan 16, 2021

📌 Commit e10555c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2021
@bors
Copy link
Contributor

bors commented Jan 17, 2021

⌛ Testing commit e10555c with merge 7d38181...

@bors
Copy link
Contributor

bors commented Jan 17, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7d38181 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2021
@bors bors merged commit 7d38181 into rust-lang:master Jan 17, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
5 participants
@syvb @rust-highfive @Mark-Simulacrum @bors @rustbot