Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle loop labels missing leading ' in different positions #81236

Merged
merged 9 commits into from
Jan 22, 2021
Merged

Gracefully handle loop labels missing leading ' in different positions #81236

merged 9 commits into from
Jan 22, 2021

Commits on Jan 22, 2021

  1. Account for labels when suggesting loop instead of while true

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    707ce2b View commit details
    Browse the repository at this point in the history

  2. Suggest 'a when given a only when appropriate 

    When encountering a name `a` that isn't resolved, but a label `'a` is
found in the current ribs, only suggest `'a` if this name is the value
expression of a `break` statement.

Solve FIXME.
    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    a701ff9 View commit details
    Browse the repository at this point in the history

  3. Add loop head span to hir

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    060dba6 View commit details
    Browse the repository at this point in the history

  4. Tweak error for invalid break expr 

    Point at loop head on invalid `break expr`.
Suggest removing `expr` or using label if available.
    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8a13abb View commit details
    Browse the repository at this point in the history

  5. Add more misspelled label tests

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    c065234 View commit details
    Browse the repository at this point in the history

  6. Avoid emitting redundant "unused label" lint

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    74ddaf0 View commit details
    Browse the repository at this point in the history

  7. Parse loop labels missing a leading ' 

    When encountering the following typo:

```rust
a: loop { break 'a; }
```

provide an appropriate suggestion.
    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8c5dafd View commit details
    Browse the repository at this point in the history

  8. Fix clippy and comment

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    7698807 View commit details
    Browse the repository at this point in the history

  9. Do not suggest using a break label when one is already present

    @estebank
    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    9e82329 View commit details
    Browse the repository at this point in the history