Add unstable option to control doctest run directory #81264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Interesting, CI actually runs compiletest from the FS root: |
Swatinem
force-pushed
the
doctest-run-directory
branch
from
3cde530
to
fcb7183
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Swatinem
force-pushed
the
doctest-run-directory
branch
from
fcb7183
to
e3d8171
Compare
jyn514
added
A-doctests
jyn514
reviewed
Jan 22, 2021
Swatinem
force-pushed
the
doctest-run-directory
branch
from
e3d8171
to
b9d371d
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This option will allow splitting the compile-time from the run-time directory of doctest invocations and is one step to solve rust-lang/cargo#8993 (comment)
Swatinem
force-pushed
the
doctest-run-directory
branch
from
b9d371d
to
9b1d27d
Compare
|
r=me with CI passing. Looks great, thanks :) |
jyn514
changed the title
|
@bors r+ |
|
📌 Commit 9b1d27d has been approved by |
bors
added
S-waiting-on-bors
|
I think this has caused this build failure: #81343 (comment) @bors r- |
|
@bors rollup=iffy |
|
@jonas-schievink wrong rustdoc PR, it was #81197 |
|
@bors r+ rollup- |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 9b1d27d has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2021
…as-schievink Rollup of 14 pull requests Successful merges: - rust-lang#75180 (Implement Error for &(impl Error)) - rust-lang#78578 (Permit mutable references in all const contexts) - rust-lang#79174 (Make std::future a re-export of core::future) - rust-lang#79884 (Replace magic numbers with existing constants) - rust-lang#80855 (Expand assert!(expr, args..) to include $crate for hygiene on 2021.) - rust-lang#80933 (Fix sysroot option not being honored across rustc) - rust-lang#81259 (Replace version_check dependency with own version parsing code) - rust-lang#81264 (Add unstable option to control doctest run directory) - rust-lang#81279 (Small refactor in typeck) - rust-lang#81297 (Don't provide backend_optimization_level query for extern crates) - rust-lang#81302 (Fix rendering of stabilization version for trait implementors) - rust-lang#81310 (Do not mark unit variants as used when in path pattern) - rust-lang#81320 (Make bad shlex parsing a pretty error) - rust-lang#81338 (Clean up `dominators_given_rpo`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Swatinem
added a commit
to Swatinem/cargo
that referenced
this pull request
Feb 22, 2021
By doing so, rustdoc will also emit workspace-relative filenames for the doctests. This was first landed in rust-lang#8954 but later backed out in rust-lang#8996 because it changed the CWD of rustdoc test invocations. The second try relies on the new `--test-run-directory` rustdoc option which was added in rust-lang/rust#81264 to explicitly control the rustdoc test cwd. fixes rust-lang#8993
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Feb 23, 2021
Run rustdoc doctests relative to the workspace By doing so, rustdoc will also emit workspace-relative filenames for the doctests. This was first landed in #8954 but later backed out in #8996 because it changed the CWD of rustdoc test invocations. The second try relies on the new `--test-run-directory` rustdoc option which was added in rust-lang/rust#81264 to explicitly control the rustdoc test cwd. fixes #8993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option will allow splitting the compile-time from the run-time
directory of doctest invocations and is one step to solve
rust-lang/cargo#8993 (comment)
r? @jyn514