-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Fix visibility of trait and impl items #81288
Conversation
Beta-nominated since this is a regression from stable to beta. Not sure if it's worth backporting, but we should definitely consider it. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with CI passing
30e8fc3
to
10a7df7
Compare
This comment has been minimized.
This comment has been minimized.
CI caught a bug: |
10a7df7
to
659d515
Compare
@jyn514 CI should pass now, but I think you should re-review as the behavior has changed. |
659d515
to
93e51b1
Compare
@bors r+ Looks great, thanks! |
📌 Commit 93e51b1 has been approved by |
…as-schievink Rollup of 15 pull requests Successful merges: - rust-lang#79841 (More clear documentation for NonNull<T>) - rust-lang#81072 (PlaceRef::ty: use method call syntax) - rust-lang#81130 (Edit rustc_middle::dep_graph module documentation) - rust-lang#81170 (Avoid hash_slice in VecDeque's Hash implementation) - rust-lang#81243 (mir: Improve size_of handling when arg is unsized) - rust-lang#81245 (Update cargo) - rust-lang#81249 (Lower closure prototype after its body.) - rust-lang#81252 (Add more self-profile info to rustc_resolve) - rust-lang#81275 (Fix <unknown> queries and add more timing info to render_html) - rust-lang#81281 (Inline methods of Path and OsString) - rust-lang#81283 (Note library tracking issue template in tracking issue template.) - rust-lang#81285 (Remove special casing of rustdoc in rustc_lint) - rust-lang#81288 (rustdoc: Fix visibility of trait and impl items) - rust-lang#81298 (replace RefCell with Cell in FnCtxt) - rust-lang#81301 (Fix small typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustdoc: Fix visibility of trait and impl items Fixes rust-lang#81274. r? `@jyn514`
[beta] backports This backports: * CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762 * Make hitting the recursion limit in projection non-fatal rust-lang#81055 * Remove incorrect `delay_span_bug` rust-lang#81532 * introduce future-compatibility warning for forbidden lint groups rust-lang#81556 * Update cargo rust-lang#81755 * rustdoc: Fix visibility of trait and impl items rust-lang#81288 * Work around missing -dev packages in solaris docker image. rust-lang#81229 * Update LayoutError/LayoutErr stability attributes rust-lang#81767 * Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257 * Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729
Fixes #81274.
r? @jyn514