-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abi field to Method
#81502
Add abi field to Method
#81502
Conversation
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
@rustbot modify labels: +T-rustdoc +A-rustdoc-json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this will conflict with the Union
change.
Maybe we should consider 'bundling' the changes together somehow so the version doesn't change as often? This isn't a breaking change either, it seems a shame - we could use |
I mean, as it's non-breaking, I think it might be okay if there's a way to get them merged in the same nightly, or such? I guess I could just make a new branch with both of these and PR it, so they merge together |
☔ The latest upstream changes (presumably #81784) made this pull request unmergeable. Please resolve the merge conflicts. |
6992aeb
to
30ecde0
Compare
Rebased. Didn't update version number yet, as I'm not sure if we want to for a non-breaking change? |
The job Click to see the possible cause of the failure (guessed by this bot)
|
rust-lang/rfcs#2963 (comment) says the main reason for a format-version is to avoid breaking changes, so I agree I don't think we need to bump it for a non-breaking change. @bors r+ |
📌 Commit ac75faf has been approved by |
☀️ Test successful - checks-actions |
Also bumps version and adds a test (Will conflict with #81500, whichever is merged first)
Rationale: It's possible for methods to have an ABI. This should be exposed in the JSON.