Fix early lints inside an async desugaring #81541
Merged
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I see @petrochenkov assigned themselves, so I'll defer the review to them. (@petrochenkov: feel free to reassign me if you don't want to take it.) |
|
@varkor I mostly wanted to be aware of the changes in this area and assigned myself to not forget. |
petrochenkov
reviewed
Feb 1, 2021
Aaron1011
force-pushed
the
early-lint-async-fn
branch
from
f112bc6 to
ab1d400
Compare
petrochenkov
added
S-waiting-on-author
Fixes rust-lang#81531 When we buffer an early lint for a macro invocation, we need to determine which NodeId to take the lint level from. Currently, we use the `NodeId` of the closest def parent. However, if the macro invocation is inside the desugared closure from an `async fn` or async closure, that `NodeId` does not actually exist in the AST. This commit explicitly calls `check_lint` for the `NodeId`s of closures desugared from async expressions, ensuring that we do not miss any buffered lints.
Aaron1011
force-pushed
the
early-lint-async-fn
branch
from
ab1d400 to
a74b2fb
Compare
|
@petrochenkov: I've updated the PR explicitly handle |
Aaron1011
added
the
S-waiting-on-review
|
Thanks! |
|
📌 Commit a74b2fb has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81531
When we buffer an early lint for a macro invocation,
we need to determine which NodeId to take the lint level from.
Currently, we use the NodeId of the closest def parent. However, if
the macro invocation is inside the desugared closure from an
async fnor async closure, that NodeId does not actually exist in the AST.
This commit uses the parent of a desugared closure when computing
lint_node_id, which is something that actually exists in the AST (anasync fnor async closure).