Add more information to the error code for 'crate not found' #81676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates src/tools/cargo. cc @ehuss |
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
jyn514
force-pushed
the
crate-not-found
branch
from
ba5fb73
to
e76185c
Compare
|
Awesome ! |
oli-obk
reviewed
Feb 3, 2021
oli-obk
reviewed
Feb 3, 2021
Comment on lines
+31
to
+34
| - You are developing the compiler itself and haven't built libstd from source. | ||
| You can usually build it with `x.py build library/std`. More information | ||
| about x.py is available in the [rustc-dev-guide]. | ||
|
|
||
| [rustc-dev-guide]: https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html#building-the-compiler |
There was a problem hiding this comment.
Hmm... this seems ok-ish to mention, but it's odd having that in the regular error message docs. That said... let's leave it in, it's pretty obvious to any reader whether it's relevant for them
There was a problem hiding this comment.
It's here partly because using ˋxpy build rustdocˋ does not build the standard library for the same stage so ˋrustup toolchain link ...ˋ works but calling the relevant compiler or rustdoc fails with this error. It's either put it here or in the dev guide but this has a lot more visibility and it doesn't take much space. This particular code shouldn't come up too often for "regular" Rust usage too and so should not confuse many people
jyn514
force-pushed
the
crate-not-found
branch
from
e76185c
to
dd6617e
Compare
|
@bors r+ rollup |
|
📌 Commit dd6617ee35c3a81d3f0a20ab2bd7f1de1dcddd30 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
Ugh, I hate submodules. |
This comes up a lot when bootstrapping.
jyn514
force-pushed
the
crate-not-found
branch
from
dd6617e
to
82914a5
Compare
|
@bors r=oli-obk |
|
📌 Commit 82914a5 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 3, 2021
Add more information to the error code for 'crate not found' This comes up a lot when bootstrapping.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 4, 2021
Add more information to the error code for 'crate not found' This comes up a lot when bootstrapping.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 4, 2021
Add more information to the error code for 'crate not found' This comes up a lot when bootstrapping.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 5, 2021
Add more information to the error code for 'crate not found' This comes up a lot when bootstrapping.
This was referenced Feb 5, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2021
Rollup of 15 pull requests Successful merges: - rust-lang#79554 (Generic associated types in trait paths) - rust-lang#80726 (relax adt unsizing requirements) - rust-lang#81307 (Handle `Span`s for byte and raw strings and add more detail ) - rust-lang#81318 (rustdoc-json: Fix has_body) - rust-lang#81456 (Make remote-test-server easier to use with new targets) - rust-lang#81497 (rustdoc: Move `display_fn` struct inside `display_fn`) - rust-lang#81500 (Remove struct_type from union output) - rust-lang#81542 (Expose correct symlink API on WASI) - rust-lang#81676 (Add more information to the error code for 'crate not found') - rust-lang#81682 (Add additional bitset benchmarks) - rust-lang#81730 (Make `Allocator` object-safe) - rust-lang#81763 (Cleanup rustdoc pass descriptions a bit) - rust-lang#81767 (Update LayoutError/LayoutErr stability attributes) - rust-lang#81771 (Indicate change in RSS from start to end of pass in time-passes output) - rust-lang#81781 (Fix `install-awscli.sh` error in CI) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up a lot when bootstrapping.