Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #[inline] to all the public IpAddr functions #81711

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Feb 3, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2021
@camelid camelid added T-libs Relevant to the library team, which will review and decide on the PR/issue. A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` labels Feb 3, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Feb 3, 2021

@saethlin Did you mark this PR as a draft on purpose, or is it ready for review?

@saethlin
Copy link
Member Author

saethlin commented Feb 3, 2021

@m-ou-se I'm looking to assess any compile time impact of this PR. I created it as a draft to link it in the zulip, but it looks like I'll be on my own to assess any compile time regression it causes.

If I can't measure a regression though (which seems likely), it's ready for review.

@saethlin
Copy link
Member Author

saethlin commented Feb 4, 2021

This produces the desired codegen change, and I cannot measure a compile time regression.

@saethlin saethlin marked this pull request as ready for review February 4, 2021 04:07
@m-ou-se m-ou-se assigned m-ou-se and unassigned joshtriplett Feb 4, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Feb 4, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 4, 2021

📌 Commit d3d0fb7 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2021
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 4, 2021
add #[inline] to all the public IpAddr functions
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2021
Rollup of 9 pull requests

Successful merges:

 - rust-lang#74304 (Stabilize the Wake trait)
 - rust-lang#79805 (Rename Iterator::fold_first to reduce and stabilize it)
 - rust-lang#81556 (introduce future-compatibility warning for forbidden lint groups)
 - rust-lang#81645 (Add lint for `panic!(123)` which is not accepted in Rust 2021.)
 - rust-lang#81710 (OsStr eq_ignore_ascii_case takes arg by value)
 - rust-lang#81711 (add #[inline] to all the public IpAddr functions)
 - rust-lang#81725 (Move test to be with the others)
 - rust-lang#81727 (Revert stabilizing integer::BITS.)
 - rust-lang#81745 (Stabilize poison API of Once, rename poisoned())

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0ddc05 into rust-lang:master Feb 5, 2021
@rustbot rustbot added this to the 1.51.0 milestone Feb 5, 2021
@saethlin saethlin deleted the ipaddr-inline branch February 5, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants