parse_format: treat r" as a literal #81828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @mbartlett21 who reported original comment. |
|
@bors r+ rollup |
|
📌 Commit 04a19b9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#71531 (Move treat err as bug tests to ui) - rust-lang#81356 (libtest: allow multiple filters) - rust-lang#81735 (faster few span methods) - rust-lang#81779 (improve error message for disallowed ptr-to-int casts in const eval) - rust-lang#81817 (Add option to emit compiler stderr per bitwidth.) - rust-lang#81828 (parse_format: treat r" as a literal) - rust-lang#81840 (fix formatting of std::iter::Map) - rust-lang#81861 (Show MIR bytes separately in -Zmeta-stats output) - rust-lang#81865 (Clean up weird Option mapping) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
format_args!internal parsing machinery to treat raw strings startingr"as a literal.Currently
"andr#are recognised as valid starting combinations for string literals, butr"is not.This was noticed when debugging #67984 (comment)
As well as fixing the behavior observed in that comment, this improves diagnostic spans for
r"formatting strings.