Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] remove #[inline] from rustc_query_system::plumbing #81892

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Feb 8, 2021

These functions have a ton of generic parameters and are instantiated
over and over again. Hopefully this will reduce binary bloat and speed
up bootstrapping times.

r? @cjgillot

These functions have a ton of generic parameters and are instantiated
over and over again. Hopefully this will reduce binary bloat and speed
up bootstrapping times.
@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Feb 8, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2021
@jyn514
Copy link
Member Author

jyn514 commented Feb 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2021
@bors
Copy link
Contributor

bors commented Feb 8, 2021

⌛ Trying commit 4f77a1a with merge 546a387ee845c330187ab104d2d62084bc990d07...

@jyn514 jyn514 added the I-heavy Issue: Problems and improvements with respect to binary size of generated code. label Feb 8, 2021
@jyn514
Copy link
Member Author

jyn514 commented Feb 8, 2021

This has had pretty good effects in the past, hopefully there's more low hanging fruit. #80831

@bors
Copy link
Contributor

bors commented Feb 8, 2021

☀️ Try build successful - checks-actions
Build commit: 546a387ee845c330187ab104d2d62084bc990d07 (546a387ee845c330187ab104d2d62084bc990d07)

@rust-timer
Copy link
Collaborator

Queued 546a387ee845c330187ab104d2d62084bc990d07 with parent 921ec4b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (546a387ee845c330187ab104d2d62084bc990d07): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2021
@cjgillot
Copy link
Contributor

cjgillot commented Feb 9, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2021

📌 Commit 4f77a1a has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2021
@bors
Copy link
Contributor

bors commented Feb 9, 2021

⌛ Testing commit 4f77a1a with merge 097bc6a...

@bors
Copy link
Contributor

bors commented Feb 9, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 097bc6a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 9, 2021
@bors bors merged commit 097bc6a into rust-lang:master Feb 9, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 9, 2021
@bors bors mentioned this pull request Feb 9, 2021
@jyn514 jyn514 deleted the no-inline branch February 9, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) I-heavy Issue: Problems and improvements with respect to binary size of generated code. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants