-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] remove #[inline]
from rustc_query_system::plumbing
#81892
Conversation
These functions have a ton of generic parameters and are instantiated over and over again. Hopefully this will reduce binary bloat and speed up bootstrapping times.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4f77a1a with merge 546a387ee845c330187ab104d2d62084bc990d07... |
This has had pretty good effects in the past, hopefully there's more low hanging fruit. #80831 |
☀️ Try build successful - checks-actions |
Queued 546a387ee845c330187ab104d2d62084bc990d07 with parent 921ec4b, future comparison URL. |
Finished benchmarking try commit (546a387ee845c330187ab104d2d62084bc990d07): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit 4f77a1a has been approved by |
☀️ Test successful - checks-actions |
These functions have a ton of generic parameters and are instantiated
over and over again. Hopefully this will reduce binary bloat and speed
up bootstrapping times.
r? @cjgillot