Commits on Feb 9, 2021

1. Rename HIR UnOp variants …

   This renames the variants in HIR UnOp from
   
       enum UnOp {
           UnDeref,
           UnNot,
           UnNeg,
       }
   
   to
   
       enum UnOp {
           Deref,
           Not,
           Neg,
       }
   
   Motivations:
   
   - This is more consistent with the rest of the code base where most enum
     variants don't have a prefix.
   
   - These variants are never used without the `UnOp` prefix so the extra
     `Un` prefix doesn't help with readability. E.g. we don't have any
     `UnDeref`s in the code, we only have `UnOp::UnDeref`.
   
   - MIR `UnOp` type variants don't have a prefix so this is more
     consistent with MIR types.
   
   - "un" prefix reads like "inverse" or "reverse", so as a beginner in
     rustc code base when I see "UnDeref" what comes to my mind is
     something like "&*" instead of just "*".

   

   osa1 committed Feb 9, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for c4e3558
   • Browse repository at this point

   Copy the full SHA

   c4e3558 View commit details

   Browse the repository at this point in the history