Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize str_split_once #81940

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Stabilize str_split_once #81940

merged 1 commit into from
Feb 26, 2021

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Feb 9, 2021

Closes #74773

@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2021
@jhpratt

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2021

Error: Label Libs-Small can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@jhpratt

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2021

Error: Label needs-fcp can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@jhpratt

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2021

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@jhpratt
Copy link
Member Author

jhpratt commented Feb 9, 2021

@rustbot modify labels to +T-libs, +A-str

Dang it rustbot let me set labels!

@rustbot rustbot added A-str Area: str and String T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 9, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 9, 2021
@jhpratt
Copy link
Member Author

jhpratt commented Feb 9, 2021

Not quite sure why this is failing, as the methods are definitely stabilized here.

@tesuji
Copy link
Contributor

tesuji commented Feb 10, 2021

tidy tool uses beta toolchain to compile ?

@jhpratt
Copy link
Member Author

jhpratt commented Feb 10, 2021

@tesuji If that's the case, why did it build before?

@tesuji
Copy link
Contributor

tesuji commented Feb 10, 2021

@tesuji If that's the case, why did it build before?

I'm not certain but one could use RUSTC_BOOTSTRAP flag to enable nightly feature on beta/stable channel.

@Mark-Simulacrum
Copy link
Member

It does look like we currently globally set RUSTC_BOOTSTRAP for all compilations - I had thought we had stopped doing so for bootstrap compiler only tools, but I guess I just wanted to for long enough that it made it happen.

I believe it should be sufficient to just leave the feature gates in for tidy and linkcheck, with a comment having the text cfg(bootstrap) in it above them - I think cfg_attr would be preferable but I'm not 100% sure it will work for the bootstrap tools (it should, though). If it doesn't then just a comment with cfg(bootstrap) on the feature gates is enough.

Otherwise it looks like this is good but will need a T-libs FCP, so once we get CI fixed I'll reassign.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt
Copy link
Member Author

jhpratt commented Feb 10, 2021

CI is green.

@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2021
@m-ou-se m-ou-se mentioned this pull request Feb 10, 2021
Closed
4 tasks
@m-ou-se m-ou-se assigned m-ou-se and unassigned Mark-Simulacrum Feb 10, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Feb 10, 2021

This is blocked on the FCP on the tracking issue: #74773 (comment)

@matklad
Copy link
Member

matklad commented Feb 25, 2021

Based on #74773 (comment)

bors r+

@m-ou-se
Copy link
Member

m-ou-se commented Feb 26, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 26, 2021

📌 Commit c28f2a8 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 26, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 26, 2021
@GuillaumeGomez
Rollup merge of rust-lang#81940 - jhpratt:stabilize-str_split_once, r…
dc34ead 
…=m-ou-se

Stabilize str_split_once

Closes rust-lang#74773
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 26, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 26, 2021
@GuillaumeGomez
Rollup merge of rust-lang#81940 - jhpratt:stabilize-str_split_once, r…
99d4d41 
…=m-ou-se

Stabilize str_split_once

Closes rust-lang#74773
This was referenced Feb 26, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2021
@bors
Auto merge of rust-lang#82552 - GuillaumeGomez:rollup-8dn1ztn, r=Guil…
9c09c1f 
…laumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#81940 (Stabilize str_split_once)
 - rust-lang#82165 (Reword labels on E0308 involving async fn return type)
 - rust-lang#82456 (Replaced some unwrap_or and map_or with lazy variants)
 - rust-lang#82491 (Consider inexpensive inlining criteria first)
 - rust-lang#82506 (Properly account for non-shorthand pattern field in unused variable lint)
 - rust-lang#82535 (Set codegen thread names)
 - rust-lang#82545 (rustdoc: add optional woff2 versions of FiraSans.)
 - rust-lang#82549 (Revert "Update normalize.css to 8.0.1")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0db8349 into rust-lang:master Feb 26, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 26, 2021
@jhpratt jhpratt deleted the stabilize-str_split_once branch February 28, 2021 19:16
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 5, 2021
@GuillaumeGomez
Rollup merge of rust-lang#81940 - jhpratt:stabilize-str_split_once, r…
8b7d335 
…=m-ou-se

Stabilize str_split_once

Closes rust-lang#74773
@NobodyXu NobodyXu mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-str Area: str and String relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for str_split_once
10 participants
@jhpratt @rust-highfive @rustbot @rust-log-analyzer @tesuji @Mark-Simulacrum @m-ou-se @matklad @bors @jonas-schievink