Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non_fmt_panic lint. #82113

Merged
merged 9 commits into from
Feb 23, 2021
Merged

Improve non_fmt_panic lint. #82113

merged 9 commits into from
Feb 23, 2021

Commits on Feb 14, 2021

  1. Fix span in non_fmt_panic for panic!(some_macro!()).

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    ef778e7 View commit details
    Browse the repository at this point in the history

  2. Add test for non_fmt_panic lint for panic!(some_macro!()).

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    1abc1e2 View commit details
    Browse the repository at this point in the history

  3. Improve suggestion for panic!(format!(..)).

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    a428ab1 View commit details
    Browse the repository at this point in the history

  4. Add test for panic!(format!(..)) lint.

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    9f97a0b View commit details
    Browse the repository at this point in the history

  5. Suggest correct replacement for panic![123]. 

    Before this change, the suggestion was `std::panic::panic_any(123]`,
changing the opening brace but not the closing one.
    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    37c532c View commit details
    Browse the repository at this point in the history

  6. Add ui tests for panic![123] and panic!{123}.

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    8ad12bb View commit details
    Browse the repository at this point in the history

  7. Formatting.

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    2a0c424 View commit details
    Browse the repository at this point in the history

  8. Only define rustc_diagnostic_item format_macro in not(test).

    @m-ou-se
    m-ou-se committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    daa371d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Add comment about how we find the right span in non_fmt_panic.

    @m-ou-se
    m-ou-se committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    ad93f48 View commit details
    Browse the repository at this point in the history