Bump FD limit for scheduler tests on OS X #8213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brson: r? |
This workaround was less than ideal. A better solution is to raise the fd limit. This reverts commit 49b72bd.
OS X defaults the ulimit for open files to 256 for programs launched from the Terminal (GUI apps get a higher default). Unfortunately this is too low for the rt tests, which deliberately overcommit and create a lot of threads (which means a lot of schedulers, and each scheduler needs at least 2 fds). By calling sysctl() and setrlimit() we can bump the fd limit up to the maximum allowed (on stock OS X it's 10240). Fixes rust-lang#7772.
|
r? @brson I had to rebase |
bors
added a commit
that referenced
this pull request
Aug 3, 2013
Revert the workaround 49b72bd and instead bump the fd limit on OS X.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
…1995 Add `manual_bits` lint Closes rust-lang#6670 --- changelog: new lint: [`manual_bits`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the workaround 49b72bd and instead bump the fd limit on OS X.