Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all InterpError allocate now, so adjust alloc-error-check #82338

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

RalfJung
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2021
@RalfJung
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2021
@bors
Copy link
Collaborator

bors commented Feb 20, 2021

⌛ Trying commit d496bfc with merge 446a538d70518d147742595eb5df8644ab3fb187...

@bors
Copy link
Collaborator

bors commented Feb 20, 2021

☀️ Try build successful - checks-actions
Build commit: 446a538d70518d147742595eb5df8644ab3fb187 (446a538d70518d147742595eb5df8644ab3fb187)

@rust-timer
Copy link
Collaborator

Queued 446a538d70518d147742595eb5df8644ab3fb187 with parent e7c23ab, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (446a538d70518d147742595eb5df8644ab3fb187): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2021
@RalfJung
Copy link
Member Author

Some green, some red... I guess that means it's neutral?^^

@oli-obk
Copy link
Contributor

oli-obk commented Feb 22, 2021

There may be some regressions in max-rss, but it's hard to tell, so in the spirit of simpler code

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 22, 2021

📌 Commit d496bfc has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2021
@bors
Copy link
Collaborator

bors commented Feb 25, 2021

⌛ Testing commit d496bfc with merge 89d32eb...

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 89d32eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 25, 2021
@bors bors merged commit 89d32eb into rust-lang:master Feb 25, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 25, 2021
@RalfJung RalfJung deleted the interp-error-allocs branch February 27, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants